Closed
Bug 1112644
Opened 10 years ago
Closed 10 years ago
make DevTools timeline tests pass with e10s
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(e10s+)
RESOLVED
FIXED
Firefox 37
Tracking | Status | |
---|---|---|
e10s | + | --- |
People
(Reporter: tromey, Assigned: tromey)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
The timeline tests in docshell/test/browser don't work with e10s yet.
Assignee | ||
Comment 1•10 years ago
|
||
This changes the timeline marker tests to work with e10s. I also took the opportunity to share code which was formerly copied into the various test files. I put the browser process code into head.js and shared content code into a new "frame-head.js".
Assignee | ||
Comment 2•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=930446c6a0e9
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8537922 [details] [diff] [review] make timeline tests work on e10s The basic idea of this patch is to split the tests into a small bit on the browser side, that loads the real tests into the content process. "ok", "is", and "info" are defined on the content side to just forward messages to the browser process.
Attachment #8537922 -
Flags: review?(paul)
Comment 5•10 years ago
|
||
Is there any value in running these tests in a remote tab? What about running them in a chrome mochitest instead? Them we would not have to deal with E10S.
Updated•10 years ago
|
tracking-e10s:
--- → +
Summary: make timeline tests pass with e10s → make DevTools timeline tests pass with e10s
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #5) > Is there any value in running these tests in a remote tab? > > What about running them in a chrome mochitest instead? Them we would not > have to deal with E10S. I didn't realize this could work for these tests. I'll investigate.
Comment 7•10 years ago
|
||
Comment on attachment 8537922 [details] [diff] [review] make timeline tests work on e10s I don't want to block this. And I believe using a chrome mochitest might not work well as we want to use an actual tab.
Attachment #8537922 -
Flags: review?(paul) → review+
Comment 9•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d51c8141591c
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d51c8141591c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Comment 11•9 years ago
|
||
Sorry for the spam. Moving bugs to Firefox :: Developer Tools: Performance Tools (Profiler/Timeline). dkl
Component: Developer Tools: Timeline → Developer Tools: Performance Tools (Profiler/Timeline)
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•