Closed Bug 1112770 Opened 10 years ago Closed 7 years ago

[gonk-l] Enable MOZ_FMP4

Categories

(Firefox OS Graveyard :: GonkIntegration, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: m1, Assigned: bwu)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1111033 +++ MOZ_FMP4 had been disabled temporarily during bring-up, but needs to be enabled eventually in L-based builds.
Hi Steven, please help to check this. thanks
Flags: needinfo?(slee)
Hi Blake, Please take this bug, thanks.
Assignee: nobody → bwu
Flags: needinfo?(slee)
Patches in Bug 1009410 needs to be ported to L code base.
More info. For MOZ_FMP4 on FFOS, Currently in master branch it is used for MSE (not default enabled yet), and not for local playback yet.
What's the progress of this issue? ready to be enabled for L?
blocking-b2g: --- → 2.2?
Flags: needinfo?(bwu)
Besides comment 4, MOZ_FMP4 is not targeted to enable on 2.2 for L.
No longer blocks: gonk-L
blocking-b2g: 2.2? → ---
Flags: needinfo?(bwu)
Sorry, I didn't notice comment 6 when I set depend in bug 1094121.
No longer blocks: gonk-L
Depends on: 1163458
To enable MOZ_FMP4 on our foxfooding device(Aries-L), we need partner's help to merge our patch in bug 1009410. That makes me think again should we have our own MediaCodec.cpp and ACodec.cpp at gecko?, since we may face this problem again and for those outside developers who want to port FxOS to other devices they may face this problem as well. Sotaro, Should we have our own MediaCodec.cpp and ACodec.cpp? I understand some partner may change these codes for their chip, but it also needs to consider the problem we are facing now. How do you think?
Flags: needinfo?(sotaro.ikeda.g)
aries's case, there is no partner outside of mozilla. And the related code is managed by the following. https://github.com/mozilla-b2g/platform_frameworks_av/tree/b2g-4.4.2_r1 You can confirm from the manifest. https://github.com/mozilla-b2g/b2g-manifest/blob/master/base-kk-aosp.xml#L7
Flags: needinfo?(sotaro.ikeda.g)
(In reply to Sotaro Ikeda [:sotaro] from comment #9) > aries's case, there is no partner outside of mozilla. And the related code > is managed by the following. > https://github.com/mozilla-b2g/platform_frameworks_av/tree/b2g-4.4.2_r1 The code is under mozilla's management.
(In reply to Blake Wu [:bwu][:blakewu] from comment #8) > To enable MOZ_FMP4 on our foxfooding device(Aries-L), we need partner's help > to merge our patch in bug 1009410. That makes me think again should we have > our own MediaCodec.cpp and ACodec.cpp at gecko?, since we may face this > problem again and for those outside developers who want to port FxOS to > other devices they may face this problem as well. > Sotaro, > Should we have our own MediaCodec.cpp and ACodec.cpp? I can not agree it if the reason is just the above thing. If we own MediaCodec.cpp and ACodec.cpp in gecko, it mean mozilla own's whole responsibility of them. Mozilla need to track every android version upate since chip vendors implement hw codec for android. And need to handle and fix hardware dependent problems. If we want to do it, we need to compare pros and cons precisely.
For aries case, just applying bug 1009410 fix to the following seems enough. https://github.com/mozilla-b2g/platform_frameworks_av/tree/b2g-4.4.2_r1
Attached patch 0001-WIP-Bug-1112770.patch (deleted) — Splinter Review
WIP. Need to work with the patch in bug 1009410.
I assume this is WONTFIX now without FxOS.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: