Boris Zbarsky [:bzbarsky] Reporter
	Description • 10 years ago

Compile error is:

 8:18.97 /Users/bzbarsky/mozilla/inbound/obj-firefox-opt/netwerk/test/tmpx_64a0.list:
 8:18.97     PropertiesTest.o
 8:18.97 
 8:18.97 Undefined symbols for architecture x86_64:
 8:18.97   "JS::GCCellPtr::GCCellPtr(JS::Value const&)", referenced from:
 8:18.97       TraceCallbackFunc::Trace(JS::Heap<JS::Value>*, char const*, void*) const in libxpcomglue_s.a(Unified_cpp_xpcom_glue0.o)
 8:18.97   "JS::GCCellPtr::outOfLineKind() const", referenced from:
 8:18.97       nsScriptObjectTracer::NoteJSChild(JS::GCCellPtr, char const*, void*) in libxpcomglue_s.a(Unified_cpp_xpcom_glue0.o)
 8:18.97 ld: symbol(s) not found for architecture x86_64

Presumably the XPCOM tests are not compiled in whatever way actually works with JS_FRIEND_API (which does not have the same linkage behavior as JS_PUBLIC_API does)...  So we need to either make this public API or fix that test to no use cycle collection or fix how it's compiled or something.

	Boris Zbarsky [:bzbarsky] Reporter
	Comment 1 • 10 years ago

Actually, I just checked and using JS_PUBLIC_API on this class doesn't seem to help either.  So it's not friend vs public but just something about how these tests link JS differently than Firefox does in --enable-shared-js builds.  Or something.

	Yuan Pengfei
	Comment 2 • 10 years ago

(In reply to Boris Zbarsky [:bz] from comment #1)
> Actually, I just checked and using JS_PUBLIC_API on this class doesn't seem
> to help either.  So it's not friend vs public but just something about how
> these tests link JS differently than Firefox does in --enable-shared-js
> builds.  Or something.

To --enable-shared-js, I have to --disable-unified-compilation.