Since bug 1113100 was landed at the same time as bug 1111504, it caused some small conflicts : - search.css forces the text to be black, even for the selected row (which has a blue background after bug 1111504), to fix this, we can simply remove the rule in search.css that forces the text color to -moz-fieldText. - Now that the selected row background is blue, the checkbox is almost invisible if the row is selected. Also, I've noticed a glitch while selecting, and hovering the items, the row sometimes blinks, but this looks rather like a platform issue.

(In reply to Tim Nguyen [:ntim] from comment #0) > Since bug 1113100 was landed [...] Argh, meant bug 1106559

Currently building to test if it works

Comment on attachment 8538600 [details] [diff] [review] Patch Review of attachment 8538600 [details] [diff] [review]: ----------------------------------------------------------------- WFM, I can't get the rows to flicker as you stated in comment #0.

Comment on attachment 8538600 [details] [diff] [review] Patch Actually, this is broken when Page Colors are disabled. We show a white checkbox on a near-white background.

Can we use the SVG checkmark here?

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5) > Can we use the SVG checkmark here? No, it doesn't work in XUL trees :(.

(In reply to Florian Quèze [:florian] [:flo] from comment #6) > (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5) > > Can we use the SVG checkmark here? > > No, it doesn't work in XUL trees :(. It seems I was wrong on this, apparently Dão successfully did it in bug 1101996.

Switched to the SVG file. Still haven't tested it locally though.

Forgot to remove the pngs in my previous patch.

Comment on attachment 8538712 [details] [diff] [review] Patch v2.1 Review of attachment 8538712 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/themes/shared/in-content/check.svg @@ +8,5 @@ > use { > fill: #2292d0; > } > + use[id$="-inverted"] { > + fill: #fff; Won't this still break if the Page Colors are disabled?

Current waiting for bug 1112566 to land before I can test things properly.

The SVG didn't work on the file-tree, but it required the width and height attributes.

Argh, wrong patch.

Comment on attachment 8539432 [details] [diff] [review] Patch v3.1 Review of attachment 8539432 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/themes/shared/in-content/check.svg @@ +15,5 @@ > } > + use[id$="-inverted"] { > + fill: #fff; > + stroke: #0095dd; > + stroke-width: 1; This is the only way I got it visible with Page Colors disabled, without changing the default styling.

[Tracking Requested - why for this release]: this bug makes the selected row of the search engines tree difficult to use. 36 is not affected as bug 1111504 didn't land there.

Florian, can you back out this rule : [0] from beta and aurora ? Bug 1087618 Part 1 didn't land on these channels, so the tree still uses the native styling, and since [0] is forcing black text, it'll likely break. [0] : https://hg.mozilla.org/releases/mozilla-beta/rev/d70d976bf024#l8.47

Comment on attachment 8539432 [details] [diff] [review] Patch v3.1 Review of attachment 8539432 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/themes/shared/in-content/check.svg @@ +15,5 @@ > } > + use[id$="-inverted"] { > + fill: #fff; > + stroke: #0095dd; > + stroke-width: 1; Let's go with `stroke-width: .5;`. With the stroke-width at 1, the inverted fill area is too skinny when Page Colors are enabled. A stroke of .5 still shows the border enough when Page Colors are disabled.

Used stroke-width: 0.5;