Untested. (Checking on something for Margaret first.) I opted to simply make the UI element invisible, trusting that this will cause the least trouble during layout.

Comment on attachment 8538723 [details] [diff] [review] Disable match case mode for find-in-page on non-Nightly builds. v1 >diff --git a/mobile/android/base/FindInPageBar.java b/mobile/android/base/FindInPageBar.java > public void onClick(View v) { > final int viewId = v.getId(); > >- if (viewId == R.id.find_matchcase) { >+ if (MATCH_CASE_ENABLED && viewId == R.id.find_matchcase) { Do we need this? I'd rather minimize the use of the const. > private void sendRequestToFinderHelper(final String request, final String searchString) { > final JSONObject json = new JSONObject(); > try { > json.put("searchString", searchString); >- json.put("matchCase", mMatchCase.isChecked()); >+ json.put("matchCase", MATCH_CASE_ENABLED && mMatchCase.isChecked()); Same here. Can't we just let the default work? Assuming mMatchCase.isChecked() returns false

(In reply to Mark Finkle (:mfinkle) from comment #2) > Do we need this? I'd rather minimize the use of the const. I guess we're not setting the click listener, so it'd be OK.

Landed with GONE instead of INVISIBLE; the empty space looks bad, but more importantly it makes the text field smaller for no reason.

Comment on attachment 8538723 [details] [diff] [review] Disable match case mode for find-in-page on non-Nightly builds. v1 Approval Request Comment [Feature/regressing bug #]: Bug 1050480. [User impact if declined]: UX not as polished as we'd like. [Describe test coverage new/current, TBPL]: N/A [Risks and why]: Approximately zero risk. Patch simply hides the UI element unless you're on Nightly. [String/UUID change made/needed]: None.

Match case mode for find-in-page is disabled in Firefox for Android 36.0a2 (2015-01-07) Device: Asus Transformer Pad TF300T (Android 4.2.1)

Verified as fixed on build 37.0a2 (2014-01-14); Device: Asus Transformer Tab (Android 4.0.3).