Closed
Bug 1113561
Opened 10 years ago
Closed 10 years ago
Only two of the previous searches are displayed in the suggestions pane of about:home
Categories
(Firefox :: Search, defect)
Firefox
Search
Tracking
()
RESOLVED
FIXED
Firefox 38
People
(Reporter: avaida, Assigned: abdelrahman, Mentored)
References
Details
Attachments
(1 file)
(deleted),
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
Reproducible on: Firefox 34.0.5 (20141126041045), Firefox 35.0b5 (20141218174327), Aurora 36.0a2 (2014-12-18), Nightly 37.0a1 (2014-12-18).
Affected platform(s): Ubuntu 12.04 LTS 32-bit, Windows 8.1 32-bit and Mac OS X 10.9.5.
STR:
1. Launch Firefox with a new profile.
2. From about:home's search bar, perform several searches for different terms, e.g. example1, example2, ..., example5.
3. Open a new tab and access about:home again.
4. Type 'example' without the apostrophe in the page's search bar.
Expected result: several past searches are displayed in the suggestions pane, along with a few suggestions for that term.
Actual result: only two random past searches are displayed in the suggestions pane (i.e. example2. example3), along with several suggestions.
Notes:
(a) The search bar displayed in the toolbar seems to display the complete search history - all five searches.
(b) If search suggestions are disabled, about:home and about:newtab display more than 2 past searches.
Comment 1•10 years ago
|
||
In the search box we use at most half of the 10 rows for history searches. It seems the about:home page uses at most 2 out of 6 rows (ie. less than half). Is this per design?
Flags: needinfo?(philipp)
Comment 2•10 years ago
|
||
I don't know if it's per design, but it seems odd.
Assuming we can't/shouldn't show more suggestions in total because of the space restrictions on about:home, it still seems sensible to have the same 50/50 split as in the search box (so a maximum of 3 history searches)
Flags: needinfo?(philipp)
Comment 3•10 years ago
|
||
The value 2 is at http://hg.mozilla.org/mozilla-central/annotate/63006936ab99/browser/modules/ContentSearch.jsm#l271
We should replace it with 3 per comment 2.
I would also like these two magic constants (3 and 6) to become consts at the top of the file with descriptive names.
Mentor: florian
Comment 4•10 years ago
|
||
(In reply to Philipp Sackl [:phlsa] please use needinfo to make me respond from comment #2)
> I don't know if it's per design, but it seems odd.
It seems this cap to 2 history entries was introduced in bug 612453 comment 30. The reason given was "since I'm not implementing scrolling". Doesn't seem very compelling :-).
Assignee | ||
Comment 5•10 years ago
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8561064 [details] [diff] [review]
rev 1 - about:home search suggestions
Review of attachment 8561064 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thanks. I wonder if about:home had tests that could break due to this change. Please push to try and run mochitest-bc tests there before making this as checkin-needed.
Attachment #8561064 -
Flags: review?(florian) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Comment 8•10 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Comment 9•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
You need to log in
before you can comment on or make changes to this bug.
Description
•