Closed
Bug 1113781
Opened 10 years ago
Closed 10 years ago
MOZ_DUMP_PAINTING builds incur FLB_LOG_PAINTED_LAYER_DECISION string formatting overhead even if we're not going to dump the layer tree
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: mstange, Assigned: BenWa)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
FLB_LOG_PAINTED_LAYER_DECISION is behind an #ifdef MOZ_DUMP_PAINTING, but it doesn't know whether we're actually going to make use of all the extra debugging data it computes, so it just does its thing unconditionally. This can cause really noticeable slowdowns when there are a lot of display items around.
I guess the problem is that FrameLayerBuilder doesn't know whether Layer::Dump is going to be called in the future. Maybe we should add a separate pref that guards FLB_LOG_PAINTED_LAYER_DECISION?
|
Assignee | |
Comment 1•10 years ago
|
||
Since we're going to make display-list working without MOZ_DUMP_PAINTING, maybe we should make sure this is now behind MOZ_DUMP_PAINTING after this happens.
|
|
Assignee | |
Comment 2•10 years ago
|
||
This will still print an empty Info: line. Probably not a big deal.
|
Reporter | |
Updated•10 years ago
|
Attachment #8539587 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8539587 -
Attachment is obsolete: true
Attachment #8543045 -
Flags: review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•