Closed
Bug 1114486
Opened 10 years ago
Closed 10 years ago
UiTour: loop.gettingStarted.url is missing a trailing slash?
Categories
(Firefox :: Tours, defect)
Tracking
()
People
(Reporter: agibson, Assigned: MattN)
References
Details
Attachments
(1 file, 1 obsolete file)
Looks like the default value for `loop.gettingStarted.url` is missing a trailing slash '/' at the end:
`https://www.mozilla.org/%LOCALE%/firefox/%VERSION%/hello/start`
I think (?) this could result in the FTE opening a new tab every time the conversation connects, as bedrock will append a trailing slash when the page opens like e.g.
https://www-demo2.allizom.org/en-US/firefox/37.0a1/hello/start/?utm_source=firefox-browser&utm_medium=firefox-browser&utm_campaign=settings-menu
When testing locally this missing trailing slash was the reason one of my machines was opening a new tab every time, while the other was not. But then I noticed the default value in Firefox is also omitting a slash.
Reporter | ||
Updated•10 years ago
|
Blocks: fx-UITour-Hello
Comment 1•10 years ago
|
||
# History
This was determined here: https://bugzilla.mozilla.org/show_bug.cgi?id=1099462#c3
I'll also mention that we'll need to double-check the Tour link from the Gears menu.
+ :jaws as he worked on the original bug.
Assignee | ||
Comment 2•10 years ago
|
||
Going to fix and try uplift to Beta today.
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Iteration: --- → 37.2
Points: --- → 1
status-firefox35:
--- → affected
status-firefox36:
--- → affected
status-firefox37:
--- → affected
Flags: qe-verify-
Flags: firefox-backlog+
Hardware: x86 → All
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8540219 -
Flags: review?(jaws)
Assignee | ||
Comment 4•10 years ago
|
||
/r/1625 - Bug 1114486 - Add a trailing slash to loop.gettingStarted.url so switchToTab works properly with the redirect adding the slash. r=jaws
Pull down this commit:
hg pull review -r 92c5974cabe078f8d12b29605e7293d360a3adc7
Assignee | ||
Comment 5•10 years ago
|
||
For more context, we need the URL path to match for switchToTab.
Updated•10 years ago
|
Attachment #8540219 -
Flags: review?(jaws) → review+
Comment 6•10 years ago
|
||
Assignee | ||
Comment 7•10 years ago
|
||
Flags: in-testsuite-
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Updated•10 years ago
|
Comment 8•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8540219 [details]
MozReview Request: bz://1114486/MattN
Approval Request Comment
[Feature/regressing bug #]: Bug 1099462
[User impact if declined]: If the URL in-product doesn't match the existing tab URL, multiple tabs may end up getting opened instead of re-using the tour tab.
[Describe test coverage new/current, TBPL]: QE will test the tour before release
[Risks and why]: Low risk one-character change adding a "/"
[String/UUID change made/needed]: None
Attachment #8540219 -
Flags: approval-mozilla-beta?
Attachment #8540219 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Attachment #8540219 -
Flags: approval-mozilla-beta?
Attachment #8540219 -
Flags: approval-mozilla-beta+
Attachment #8540219 -
Flags: approval-mozilla-aurora?
Attachment #8540219 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 10•10 years ago
|
||
Assignee | ||
Comment 11•9 years ago
|
||
Attachment #8540219 -
Attachment is obsolete: true
Attachment #8618944 -
Flags: review+
Assignee | ||
Comment 12•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•