Roland Mainz Assignee
	Description • 23 years ago

bug 84947 ("We need a "better" print dialog...") introduced a new print dialog
for Unix+OS/2.
Unfortunately it seems that I missed that BeOS uses the PostScript module for
printing, too - therefore we have to port the changes "done" to the Xlib/GTK+
widget code to BeOS, too...

Looking at attachment 58681 [details] [diff] [review] and grep'ping out the Xlib toolkit changes:
The following files have been changed - we only have to port the changes to the
matching BeOS files:
-- snip --
mozilla/gfx/src/xlib/Makefile.in
mozilla/gfx/src/xlib/nsDeviceContextSpecXlib.cpp
mozilla/gfx/src/xlib/nsDeviceContextSpecXlib.h
mozilla/gfx/src/xlib/nsGfxFactoryXlib.cpp
mozilla/gfx/src/xlib/nsPrintdXlib.h
-- snip --

I do not have a BeOS build box... I need help ...

	Roland Mainz Assignee
	Comment 1 • 23 years ago

CC:'ing more BeOS folks ...

	Roland Mainz Assignee
	Comment 2 • 23 years ago

Taking ...

	Roland Mainz Assignee
	Comment 6 • 23 years ago

AFAIK the attached patch should work... can someone please test it ?

	David Baron :dbaron:
	Comment 7 • 23 years ago

Checked in patch 2001-11-23 18:39 PDT.

	Roland Mainz Assignee
	Comment 8 • 23 years ago

dbaron:
1. Thank you very much for fixing "bewildered"!
2. Can we mark this bug as FIXED ? The BeOS tinderbox isn't RED anymore - and it
was ORANGE before the landing of the new print dialog ...

	Paul
	Comment 9 • 23 years ago

I just did a checkout and built the latest tree. The new dialog seems to be OK. (it didn't crash :)

	Roland Mainz Assignee
	Comment 10 • 23 years ago

Marking "FIXED" per Arougthopher's comment (comment #9).

----

Arougthopher:
It builds and does not crash - but does it work, too ?

	Paul
	Comment 11 • 23 years ago

No, it does not work, since printing has not been implemented on BeOS, YET.  This is on my list of todos, but there are some bug fixes that need work before that.

	sujay
	Comment 12 • 23 years ago

Roland, can you verify this and mark verified-fixed? thanks.

	sujay
	Comment 13 • 23 years ago

oops accidentally marked verified.

	sujay
	Comment 14 • 23 years ago

marking fixed again....please verify Roland...

	Roland Mainz Assignee
	Comment 15 • 23 years ago

VERIFYING per comment #9 ...