Assuming part 2 of bug 1095278 lands as is.

including testAboutPasswords

Comment on attachment 8644062 [details] [diff] [review] aboutLoginsRemoveNightlyFlags Review of attachment 8644062 [details] [diff] [review]: ----------------------------------------------------------------- This looks mostly good, but you're missing changes in AboutRedirector.js, the menu item in BrowserApp.java, GeckoPreferences.java, and a few tests (testSystemPages, testSettingsMenuItems). This is just from a quick mxr search, so double check to make sure there aren't any other places where you're missing NIGHTLY flags.

Let's make sure we uplift this after it's done.

pending try results

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9acdbb9472c2 weekend's try busted. let's see if I got it all this time.

try's happy.

Chenxia, any estimate as to when you might get around to this review? Would you like me to find another reviewer?

Comment on attachment 8645908 [details] [diff] [review] removeNightlyOnlyFlagsAboutLogins Review of attachment 8645908 [details] [diff] [review]: ----------------------------------------------------------------- A little more cleanup, but this is good to go. ::: mobile/android/base/preferences/GeckoPreferences.java @@ -735,5 @@ > preferences.removePreference(pref); > i--; > continue; > } > - } else if (PREFS_LOGIN_MANAGE.equals(key)) { Remove this local variable declaration too, as well as the android:key from the corresponding xml layout file. ::: mobile/android/tests/browser/robocop/testSettingsMenuItems.java @@ -195,5 @@ > } > > - if (!AppConstants.NIGHTLY_BUILD) { > - final List<String[]> privacy = settingsMap.get(PATH_PRIVACY); > - privacy.remove(MANAGE_LOGINS_ARR); Remove this array declaration since it's unused now. ::: mobile/android/tests/browser/robocop/testSystemPages.java @@ -98,5 @@ > verifyTabCount(expectedTabCount); > } > } > > private boolean skipItemURL(String item) { Remove this entire method, because this is the only used for logins and we'd just be making a bunch of calls to a method that always returns false.

try looks pretty green https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a1a2475b5a3

Comment on attachment 8645908 [details] [diff] [review] removeNightlyOnlyFlagsAboutLogins Approval Request Comment [Feature/regressing bug #]: about:logins [User impact if declined]: users will be unable to access to login/password manager at all [Describe test coverage new/current, TreeHerder]:all logins tests have been unblocked and will no longer be skipped [Risks and why]: ^ [String/UUID change made/needed]: none

Comment on attachment 8645908 [details] [diff] [review] removeNightlyOnlyFlagsAboutLogins We want this feature to be available.

Release Note Request (optional, but appreciated) [Why is this notable]: I guess this is a new feature on mobile [Suggested wording]: Login and password manager [Links (documentation, blog post, etc)]:

Relnotes in bug 1170786