Closed Bug 1115247 Opened 10 years ago Closed 10 years ago

Create ViewManager to replace render.js

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-master fixed)

RESOLVED FIXED
2.2 S4 (23jan)
Tracking Status
b2g-master --- fixed

People

(Reporter: rudyl, Assigned: rudyl)

References

Details

Attachments

(1 file)

(deleted), text/x-github-pull-request
timdream
: review+
timdream
: feedback+
Details
We should have a ViewManager component, which follows instantiable pattern and will be able to replace render.js.
Assignee: nobody → rlu
Status: NEW → ASSIGNED
Attached file Patch V1 (deleted) —
WIP here to create ViewManager to replace render.js. Tim, if possible, please help give early feedback per this commit, https://github.com/RudyLu/gaia/commit/79cf6311e5196dbeda765890a4305ba82c14ee07 This is based on the previous work of view re-org, but it was not landed yet due to test issues. Thanks.
Attachment #8547503 - Flags: feedback?(timdream)
Comment on attachment 8547503 [details] Patch V1 Nice clean up. I wonder if you want to re-organize the APIs in this bug or in future bugs -- as we have discussed, the way IMERender works with controller logic doesn't make a lot of sense currently. This patch simply make ViewManager inherits that. BTW you have not remove the render.js from the tree, even though it's not build anymore.
Attachment #8547503 - Flags: feedback?(timdream) → feedback+
I was working on a WIP patch to get the APIs saner, however, I think I should get this bug done first to unblock any potential changes to view related code. So create another bug to track the API re-org work, Bug 1122453.
Comment on attachment 8547503 [details] Patch V1 The review comments have been addressed and unit tests are ready (though, it seems gaia-try was not triggered). Tim, could you please help review it again? Thank you very much!
Attachment #8547503 - Attachment description: WIP → Patch V1
Attachment #8547503 - Flags: review?(timdream)
Comment on attachment 8547503 [details] Patch V1 The improvement of the APIs probably takes more than bug 1122453 to complete. This patch along provide a good foundation to work on those bugs although itself doesn't do a lot (other than enabling us to test separate ViewManager instances than re-testing the one-and-only IMERender). Let's land this first if there aren't known regressions.
Attachment #8547503 - Flags: review?(timdream) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S4 (23jan)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: