Closed
Bug 1115247
Opened 10 years ago
Closed 10 years ago
Create ViewManager to replace render.js
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(b2g-master fixed)
RESOLVED
FIXED
2.2 S4 (23jan)
Tracking | Status | |
---|---|---|
b2g-master | --- | fixed |
People
(Reporter: rudyl, Assigned: rudyl)
References
Details
Attachments
(1 file)
We should have a ViewManager component, which follows instantiable pattern and will be able to replace render.js.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → rlu
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
WIP here to create ViewManager to replace render.js.
Tim, if possible, please help give early feedback per this commit,
https://github.com/RudyLu/gaia/commit/79cf6311e5196dbeda765890a4305ba82c14ee07
This is based on the previous work of view re-org, but it was not landed yet due to test issues.
Thanks.
Attachment #8547503 -
Flags: feedback?(timdream)
Comment 2•10 years ago
|
||
Comment on attachment 8547503 [details]
Patch V1
Nice clean up. I wonder if you want to re-organize the APIs in this bug or in future bugs -- as we have discussed, the way IMERender works with controller logic doesn't make a lot of sense currently. This patch simply make ViewManager inherits that.
BTW you have not remove the render.js from the tree, even though it's not build anymore.
Attachment #8547503 -
Flags: feedback?(timdream) → feedback+
Assignee | ||
Comment 3•10 years ago
|
||
I was working on a WIP patch to get the APIs saner, however, I think I should get this bug done first to unblock any potential changes to view related code.
So create another bug to track the API re-org work, Bug 1122453.
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8547503 [details]
Patch V1
The review comments have been addressed and unit tests are ready (though, it seems gaia-try was not triggered).
Tim, could you please help review it again?
Thank you very much!
Attachment #8547503 -
Attachment description: WIP → Patch V1
Attachment #8547503 -
Flags: review?(timdream)
Comment 5•10 years ago
|
||
Comment on attachment 8547503 [details]
Patch V1
The improvement of the APIs probably takes more than bug 1122453 to complete.
This patch along provide a good foundation to work on those bugs although itself doesn't do a lot (other than enabling us to test separate ViewManager instances than re-testing the one-and-only IMERender).
Let's land this first if there aren't known regressions.
Attachment #8547503 -
Flags: review?(timdream) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/78773e0ff21e257b5f6539781e15e05ba9cf1873
--
Thanks.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-master:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S4 (23jan)
You need to log in
before you can comment on or make changes to this bug.
Description
•