Closed
Bug 1115290
Opened 10 years ago
Closed 10 years ago
[Stingray][System] system app tries to focus a non-focusable element
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: johnhu, Assigned: rexboy)
References
Details
(Whiteboard: [ft:conndevices] [Stingray-Branch] [picked 1/29])
Attachments
(1 file)
We got the same issue in Stingray project.
+++ This bug was initially created as a clone of Bug #1115277 +++
Few modules try to focus a non-focusable, tabIndex=-1, element while they show up.
Like:
[1] https://github.com/mozilla-b2g/gaia/blob/d55d1d5f39bd338ab2d298823aab1121e3d73fef/apps/system/js/app_modal_dialog.js#L226
[2] https://github.com/mozilla-b2g/gaia/blob/d55d1d5f39bd338ab2d298823aab1121e3d73fef/apps/system/js/modal_dialog.js#L213
For those cases, we should focus the first focusable element, like ok button or cancel button.
|
||
Updated•10 years ago
|
Assignee: nobody → 938.daisuke
|
|
||
Comment 1•10 years ago
|
||
Kusaba-san, please verify if this happens on your side, if not, feel free to close it. If yes, we may need your help to fix it. Thank you.
|
||
Updated•10 years ago
|
Flags: needinfo?(938.daisuke)
Whiteboard: [ft:conndevices]
|
|
||
Comment 2•10 years ago
|
||
Rex, assign this bug to you. Please separate your work on bug 1105981 and fix ModalDialog focus issue here. Thanks
Assignee: 938.daisuke → rexboy
Flags: needinfo?(rexboy)
|
|
||
Updated•10 years ago
|
Whiteboard: [ft:conndevices] → [ft:conndevices] [Stingray-Branch]
|
|
||
Updated•10 years ago
|
Whiteboard: [ft:conndevices] [Stingray-Branch] → [ft:conndevices]
|
Assignee | |
Comment 3•10 years ago
|
||
This PR contains two patches. please review the commit just for this bug.
Flags: needinfo?(rexboy)
Attachment #8552949 -
Flags: review?(im)
|
Reporter | |
Comment 4•10 years ago
|
||
Comment on attachment 8552949 [details]
Patch
For smart-system part, it looks ok. But please update the code based on our discussion at this morning. I had put some comments at PR. Please check them, too.
Attachment #8552949 -
Flags: review?(im) → review+
|
|
||
Comment 5•10 years ago
|
||
Hi Rex, any update for the Comment 4?
Flags: needinfo?(938.daisuke) → needinfo?(rexboy)
|
|
Assignee | |
Comment 6•10 years ago
|
||
I've already updated it, but Gaia test keeps failing since yesterday. I'll land it once tests becomes green.
Flags: needinfo?(rexboy)
|
||
Updated•10 years ago
|
Whiteboard: [ft:conndevices] → [ft:conndevices] [Stingray-Branch]
|
|
Assignee | |
Comment 7•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [ft:conndevices] [Stingray-Branch] → [ft:conndevices] [Stingray-Branch] [picked 1/29]
You need to log in
before you can comment on or make changes to this bug.
Description
•