Closed
Bug 1115387
Opened 10 years ago
Closed 10 years ago
BaselineIC call should register a template object for SIMD call hook.
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: nbp, Assigned: nbp)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Currently baseline only register a template object on the classHook only if the hook is TypedObject::construct, we should add a new one such that we can inline the SIMD object creation in Ion.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8541284 -
Flags: review?(jdemooij)
|
||
Updated•10 years ago
|
Attachment #8541284 -
Flags: review?(jdemooij) → review+
|
||
Comment 2•10 years ago
|
||
sorry had to back this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=bbb0b9dffd36 for bustages across platforms like:
https://treeherder.mozilla.org/logviewer.html#?job_id=4999847&repo=mozilla-inbound
|
|
Assignee | |
Comment 3•10 years ago
|
||
Apparently there was a rebase issue, and the change from this patch moved from GetTemplateObjectForClassHook into TryAttachFunCallStub. I have no idea why git decided that this was the way to merge this change :/
I'll run a new try run with this fixed, and land it again.
|
||
Comment 4•10 years ago
|
||
|
|
Assignee | |
Comment 5•10 years ago
|
||
|
||
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•