Closed
Bug 1115575
Opened 10 years ago
Closed 10 years ago
Error: formatURLPref: Couldn't get pref: browser.search.geoip.url
Categories
(SeaMonkey :: General, defect)
SeaMonkey
General
Tracking
(seamonkey2.34 fixed)
RESOLVED
WORKSFORME
seamonkey2.34
| Tracking | Status | |
|---|---|---|
| seamonkey2.34 | --- | fixed |
People
(Reporter: philip.chee, Assigned: philip.chee)
References
Details
(Whiteboard: [fixed by Bug 1117158])
Attachments
(1 file)
|
(deleted),
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
Fri Dec 26 2014 04:46:19
Error: formatURLPref: Couldn't get pref: browser.search.geoip.url
Source file: resource://gre/components/nsURLFormatter.js
Line: 136
Cause: Bug 1109120 - use a geoip xhr request for more reliable country detection for search
|
Assignee | |
Comment 1•10 years ago
|
||
> +pref("browser.search.geoip.url", "https://location.services.mozilla.com/v1/country?key=no-mozilla-api-key");
Pref with dummy key "no-mozilla-api-key" to stop nsURLFormatter.js from complaining.
Attachment #8541519 -
Flags: review?(iann_bugzilla)
Comment on attachment 8541519 [details] [diff] [review]
Patch v.0 add prefs
Does it matter that we get a parse error back when we send the "no-mozilla-api-key"? Should the comment mention why we're we using this dummy key?
Attachment #8541519 -
Flags: review?(iann_bugzilla) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/93f1fda728f7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-seamonkey2.34:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.34
|
|
Assignee | |
Comment 4•10 years ago
|
||
Bug 1117158 moved the relevant prefs to all.js rendering this bug superfluous. I'll backout 93f1fda728f7 RSN.
(From bug 1117158 comment #17)
> (In reply to Philip Chee from comment #16)
>> https://hg.mozilla.org/mozilla-central/rev/20dd052812f8#l4.21
>> When building SeaMonkey (or Thunderbird) what do we use for
>> %MOZILLA_API_KEY% ?
>
> I'm not sure if this answers your question, but configure.in has a default
> value for MOZILLA_API_KEY=no-mozilla-api-key -
> https://dxr.mozilla.org/mozilla-central/source/configure.in#4026. This is
> what desktop is currently using and I guess/hope that SeaMonkey/TB will use
> this initially.
>
> Bug 1113606 exists to get a "real" key for each of our channels (although
> IIUC, Nightly will always still get that default rather than a
> nightly-specific key) - I suspect that we need matching bugs for those other
> products, but also suspect that the default value will continue to work for
> some time simply as it will need to for Nightly.
|
|
Assignee | |
Comment 5•10 years ago
|
||
pushed backout patch to comm-central:
http://hg.mozilla.org/comm-central/rev/756da409acdb
> I'm not sure if this answers your question, but configure.in has a default
> value for MOZILLA_API_KEY=no-mozilla-api-key -
> https://dxr.mozilla.org/mozilla-central/source/configure.in#4026.
http://mxr.mozilla.org/comm-central/source/mozilla/configure.in?rev=bf12689b10f8&mark=4022-4024#4017
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Depends on: 1109120
Resolution: --- → WONTFIX
Whiteboard: [fixed by Bug 1117158]
|
|
Assignee | |
Updated•10 years ago
|
Resolution: WONTFIX → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•