Closed
Bug 1115691
Opened 10 years ago
Closed 10 years ago
track counts of frames constructed and frames reflowed
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: dbaron, Assigned: dbaron)
References
(Depends on 1 open bug)
Details
Attachments
(2 files, 2 obsolete files)
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
We should keep track of counts of frames constructed (excluding breaking!) and frames reflowed so that we can:
* write tests that assert that these things have or have not happened
* write developer tools that do the same
I plan to use this for testing bug 1110277.
Assignee | ||
Comment 1•10 years ago
|
||
(I've tested the frame construction counts in my test for bug 1110277; I
haven't actually tested the reflow counts.)
Attachment #8541737 -
Flags: review?(mats)
Assignee | ||
Comment 2•10 years ago
|
||
This counts are intended to be useful for:
* tests
* perhaps developer tools
that need to determine whether frame construction or reflow has happened
in a particular interval.
Attachment #8541738 -
Flags: review?(mats)
Assignee | ||
Updated•10 years ago
|
Attachment #8541737 -
Flags: review?(mats) → review?(roc)
Assignee | ||
Updated•10 years ago
|
Attachment #8541738 -
Flags: review?(mats) → review?(roc)
Comment on attachment 8541737 [details] [diff] [review]
patch 1 - Store counts of frames constructed and reflowed on the pres context
Review of attachment 8541737 [details] [diff] [review]:
-----------------------------------------------------------------
I think you should use 64 bits. A page with 1000 frames reflowing 60 times per second for a day will overflow 32 bits.
Attachment #8541737 -
Flags: review?(roc) → review-
Assignee | ||
Comment 4•10 years ago
|
||
(I've tested the frame construction counts in my test for bug 1110277; I
haven't actually tested the reflow counts.)
Attachment #8545556 -
Flags: review?(roc)
Assignee | ||
Updated•10 years ago
|
Attachment #8541737 -
Attachment is obsolete: true
Assignee | ||
Comment 5•10 years ago
|
||
This counts are intended to be useful for:
* tests
* perhaps developer tools
that need to determine whether frame construction or reflow has happened
in a particular interval.
Attachment #8545557 -
Flags: review?(roc)
Assignee | ||
Updated•10 years ago
|
Attachment #8541738 -
Attachment is obsolete: true
Attachment #8541738 -
Flags: review?(roc)
Attachment #8545556 -
Flags: review?(roc) → review+
Attachment #8545557 -
Flags: review?(roc) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d1510c5deff9
https://hg.mozilla.org/mozilla-central/rev/9fe58932c192
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•