Closed Bug 1115741 Opened 10 years ago Closed 10 years ago

Wrap W3C Notifications in NotificationHelper

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1111841

People

(Reporter: zbraniecki, Unassigned, Mentored)

References

Details

The new NotificationHelper (bug 1095109) provides a cleaner API to localize notifications. As part of the effort to remove mozL10n.get uses, we should migrate all uses of W3C Notification to use NotificationHelper. Use: grep -I -r "new Notification" ./apps/ to find all raw Notification uses, and: https://github.com/mozilla-b2g/gaia/blob/0833002fdf6a33d44590d6b8c728a03f7eccd977/apps/costcontrol/js/message_handler.js#L175-L180 to see an example of NotificationHelper API use. You can also read documentation here: https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/localization_code_best_practices#Notification_API Excluding tests, there are around 20 uses of W3C Notification that should be wrapped.
Blocks: 1020138
Mentor: gandalf
Whiteboard: [good first bug]
Gosh...
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Whiteboard: [good first bug]
You need to log in before you can comment on or make changes to this bug.