Closed Bug 1115758 Opened 10 years ago Closed 10 years ago

Add Cancel method for USSDSession

Categories

(Firefox OS Graveyard :: RIL, defect)

Product:
Firefox OS Graveyard
Component:
RIL
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.2+)

Status:
RESOLVED FIXED
Milestone:
2.2 S4 (23jan)
Project Flags:
feature-b2g 2.2+

People

(Reporter: anshulj, Assigned: aknow)

References

Details

Attachments

(5 files, 6 obsolete files)

[final] Part 1: Add USSDSession.cancel (webidl). r=hsinyi
(deleted), patch
aknow
: review+
Details | Diff | Splinter Review
[final] Part 2: Add USSDSession.cancel (dom). r=hsinyi
(deleted), patch
aknow
: review+
Details | Diff | Splinter Review
[final] Part 3: Add nsITelephonyService.cancelUSSD (idl). r=hsinyi
(deleted), patch
aknow
: review+
Details | Diff | Splinter Review
[final] Part 4: Add nsITelephonyService.cancelUSSD (ipc). r=hsinyi
(deleted), patch
aknow
: review+
Details | Diff | Splinter Review
[final] Part 5: Add nsITelephonyService.cancelUSSD (ril). r=hsinyi
(deleted), patch
aknow
: review+
Details | Diff | Splinter Review
This is a clone of bug 1058397#c57.
Assignee: nobody → szchen
Attached patch Part 1: Add USSDSession.cancel (webidl) (obsolete) (deleted) — — Splinter Review
Attachment #8542049 - Flags: review?(htsai)
Attached patch Part 2: Add USSDSession.cancel (dom) (obsolete) (deleted) — — Splinter Review
Attachment #8542050 - Flags: review?(htsai)
Attachment #8542051 - Flags: review?(htsai)
Attachment #8542052 - Flags: review?(htsai)
Attachment #8542053 - Flags: review?(htsai)
triage: this should be feature-b2g:2.2 since it's blocking CAF 2.2 FL requirements. Let's target on Jan23.
Blocks: CAF-v2.2-metabug
No longer blocks: CAF-v2.1-CC-metabug
blocking-b2g: 2.2? → ---
feature-b2g: --- → 2.2+
Target Milestone: --- → 2.2 S4 (23jan)
Attachment #8542049 - Flags: review?(htsai) → review+
Attachment #8542051 - Flags: review?(htsai) → review+
Attachment #8542050 - Flags: review?(htsai) → review+
Comment on attachment 8542052 [details] [diff] [review] Part 4: Add nsITelephonyService.cancelUSSD (ipc) Review of attachment 8542052 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/telephony/ipc/TelephonyIPCService.cpp @@ +318,5 @@ > } > > NS_IMETHODIMP > +TelephonyIPCService::CancelUSSD(uint32_t aClientId, > + nsITelephonyCallback *aCallback) nit: indention ::: dom/telephony/ipc/TelephonyParent.h @@ +127,5 @@ > bool > DoRequest(const DialRequest& aRequest); > > bool > DoRequest(const USSDRequest& aRequest); Since we are going to have CancelUSSDRequest, can we change USSDRequest to SendUSSDRequest for clearer naming?
Attachment #8542052 - Flags: review?(htsai)
Attachment #8542053 - Flags: review?(htsai) → review+
Attachment #8542052 - Attachment is obsolete: true
Attachment #8544338 - Flags: review?(htsai)
Comment on attachment 8544338 [details] [diff] [review] Part 4#2: Add nsITelephonyService.cancelUSSD (ipc) Review of attachment 8544338 [details] [diff] [review]: ----------------------------------------------------------------- Thank you!
Attachment #8544338 - Flags: review?(htsai) → review+
Attachment #8542049 - Attachment is obsolete: true
Attachment #8545075 - Flags: review+
Attachment #8542050 - Attachment is obsolete: true
Attachment #8545076 - Flags: review+
Blocks: CAF-v3.0-FL-metabug
No longer blocks: CAF-v3.0-FL-metabug
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: