Closed
Bug 1115924
Opened 10 years ago
Closed 10 years ago
InContent prefs - Eliminate double borders from buttons and links in high contrast mode
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
Firefox 38
| Tracking | Status | |
|---|---|---|
| firefox38 | --- | fixed |
People
(Reporter: ntim, Assigned: Paenglab)
References
Details
(Whiteboard: [testday-20150901])
Attachments
(2 files)
|
(deleted),
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
image/png
|
Details |
borders.png
The second border is basically a transparent border that turns into a dotted one when focused. Unfortunatly, transparent turns into a visible color in HC mode.
Here's the quickest fix I could find :
menulist:not(:-moz-focusring) > hbox,
button:not(.help-button):not(:-moz-focusring) > hbox,
.text-link:not(:-moz-focusring) {
border-style: none;
}
|
||
Comment 1•10 years ago
|
||
De-listing from the hard-blocker tracking since this is a polish-related bug in high-contrast mode, which is not frequently used.
|
Assignee | |
Comment 2•10 years ago
|
||
Simply add selectors to the already existing rules.
|
Reporter | |
Comment 3•10 years ago
|
||
Comment on attachment 8557631 [details] [diff] [review]
NoFocusringBorder.patch
I'm not sure this is a Windows only issue. Page Colors settings are also on OSX and Linux right ? And Linux also has HC themes too.
|
|
Reporter | |
Comment 4•10 years ago
|
||
(In reply to Tim Nguyen [:ntim] from comment #3)
> Comment on attachment 8557631 [details] [diff] [review]
> NoFocusringBorder.patch
>
> I'm not sure this is a Windows only issue. Page Colors settings are also on
> OSX and Linux right ? And Linux also has HC themes too.
Oh, I see there were existing rules already. Nevermind.
|
|
Assignee | |
Comment 5•10 years ago
|
||
It's a Windows only issue. Checked with page colors disabled on Linux and OS X.
|
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8557631 [details] [diff] [review]
NoFocusringBorder.patch
I can't reproduce this bug using Firefox Nightly 38.0a1 (2015-02-11) on Windows 8.1 with the High Contrast White theme enabled and tabbing through the buttons as well as the clicking on the buttons.
Flags: needinfo?(richard.marti)
Attachment #8557631 -
Flags: review?(jaws)
|
|
Assignee | |
Comment 7•10 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #6)
> Comment on attachment 8557631 [details] [diff] [review]
> NoFocusringBorder.patch
>
> I can't reproduce this bug using Firefox Nightly 38.0a1 (2015-02-11) on
> Windows 8.1 with the High Contrast White theme enabled and tabbing through
> the buttons as well as the clicking on the buttons.
The screenshot is from Win 7 but I see this also under Win 8. The focus ring is good visible around the "Learn more" links and also the second border inside the menulists. The button's focusring is almost not visible because it looks like a normal 2px border but it's the 1px border plus the 1px focusring.
Flags: needinfo?(richard.marti) → needinfo?(jaws)
|
|
||
Comment 8•10 years ago
|
||
Comment on attachment 8557631 [details] [diff] [review]
NoFocusringBorder.patch
Review of attachment 8557631 [details] [diff] [review]:
-----------------------------------------------------------------
Ok, I can see the change now. Thanks!
Attachment #8557631 -
Flags: review+
|
|
||
Updated•10 years ago
|
Flags: needinfo?(jaws)
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 9•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 10•10 years ago
|
||
|
|
||
Comment 11•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
|
||
Comment 12•9 years ago
|
||
This is verified fixed in a QA test day.
Status: RESOLVED → VERIFIED
Whiteboard: [testday-20150901]
You need to log in
before you can comment on or make changes to this bug.
Description
•