Closed Bug 1115935 Opened 10 years ago Closed 10 years ago

Let us opt out of the "Mobile" part in the UA string

Categories

(Firefox OS Graveyard :: Runtime, defect)

Product:
Firefox OS Graveyard
Component:
Runtime
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: fabrice, Assigned: fabrice)

References

Details

Attachments

(1 file, 2 obsolete files)

simulator-ua.patch
(deleted), patch
gal
: review+
Details | Diff | Splinter Review 
Currently all b2g builds either send "Tablet" or "Mobile". That doesn't make sense on desktop for firefox.html
Attached patch b2g-ua.patch (obsolete) (deleted) — — Splinter Review 
Adds support for a b2g.ua.no_forced_mobile pref.
Attached patch htmlrunner-ua.patch (obsolete) (deleted) — — Splinter Review 
Opting out from adding Mobile or Tablet when running htmlrunner, except if running on gonk.
Attachment #8541894 - Attachment is obsolete: true
Attached patch simulator-ua.patch (deleted) — — Splinter Review 
Ok, 3rd time's a charm...

Currently we set the `Mobile` token on device (ANDROID==1) and on all b2g products so that webcompat can test easily. However that does not make sense to add this token on b2g desktop in general, except when using the simulator.
So this patch just switch to check if we are using the simulator, not MOZ_B2G. That let browser.html get non-mobile sites on desktop.
Attachment #8550107 - Attachment is obsolete: true
Attachment #8550819 - Flags: review?(gal)
Attachment #8550819 - Flags: review?(gal) → review+
https://hg.mozilla.org/integration/b2g-inbound/rev/1235f3d789ba
https://hg.mozilla.org/mozilla-central/rev/1235f3d789ba
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: