Unless a user chose to preserve significantly more history than the Firefox default, on a recent profile there should be no downloads without the target file name annotation in the Places database. So, while it was useful during the transition period from old versions, now we can safely remove the fallback to the Places title for the item display name, and just use the download URI we would use for an empty title, simplifying the code.

Comment on attachment 8541914 [details] [diff] [review] The patch Review of attachment 8541914 [details] [diff] [review]: ----------------------------------------------------------------- it sounds ok. I was wondering if there could be any issue with history removal, but then the download should disappear from the view too, so no reasons to care about the title. I "like" how we lack any kind of testing on this stuff :(

where did we remove nodeAnnotationChanged?

(In reply to Marco Bonardo [::mak] (needinfo? me) from comment #2) > where did we remove nodeAnnotationChanged? ah found it, I think you should reverse the dependencies here, see https://bugzilla.mozilla.org/show_bug.cgi?id=1115972#c2