Closed
Bug 1116304
Opened 10 years ago
Closed 9 years ago
context menu too big / nonnative for in-content prefs password manager
Categories
(Firefox :: Settings UI, defect, P4)
Firefox
Settings UI
Tracking
()
RESOLVED
DUPLICATE
of bug 1247214
People
(Reporter: Dolske, Unassigned)
References
Details
(Whiteboard: [sf-hackweek])
Attachments
(2 files)
Too big
See screenshot. The in-content prefs has a content menu that's way too big and non-native. It's ok in other places, so far I've only noticed it in the password manager.
|
Reporter | |
Comment 1•10 years ago
|
||
|
||
Comment 3•10 years ago
|
||
I think this should block shipping, if only because there are a number of these size bugs which should be fixable in one fell swoop, and together they should block shipping. :-)
Blocks: ship-incontent-prefs
|
||
Comment 4•10 years ago
|
||
This will be true of any context menu in a dialog (here, popup exceptions, cookie exceptions, show cookies, addon install exceptions).
https://dxr.mozilla.org/mozilla-central/source/browser/themes/osx/preferences/in-content/dialog.css#12
https://dxr.mozilla.org/mozilla-central/source/browser/themes/linux/preferences/in-content/dialog.css#7
https://dxr.mozilla.org/mozilla-central/source/browser/themes/windows/preferences/in-content/dialog.css#7
|
||
Comment 5•10 years ago
|
||
(In reply to Ian Moody (:Kwan) from comment #4)
Thanks for finding that. Would you be interested in putting together a patch to fix this?
Flags: needinfo?(moz-ian)
|
|
||
Comment 6•10 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5)
> (In reply to Ian Moody (:Kwan) from comment #4)
>
> Thanks for finding that. Would you be interested in putting together a patch
> to fix this?
Yeah I'd be willing to do so.
Not sure what the best approach would be though. There's no obvious :-moz-anonymous-content/:-moz-xbl-generated I can see on MDN that I could :not().
Flags: needinfo?(moz-ian)
|
|
||
Comment 7•10 years ago
|
||
(In reply to Ian Moody (:Kwan) from comment #6)
> (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5)
> > (In reply to Ian Moody (:Kwan) from comment #4)
> >
> > Thanks for finding that. Would you be interested in putting together a patch
> > to fix this?
>
> Yeah I'd be willing to do so.
> Not sure what the best approach would be though. There's no obvious
> :-moz-anonymous-content/:-moz-xbl-generated I can see on MDN that I could
> :not().
Does switching these rules to rem instead of em work? (Might not, but worth a shot)
|
|
||
Comment 8•10 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #7)
> (In reply to Ian Moody (:Kwan) from comment #6)
> > (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5)
> > > (In reply to Ian Moody (:Kwan) from comment #4)
> > >
> > > Thanks for finding that. Would you be interested in putting together a patch
> > > to fix this?
> >
> > Yeah I'd be willing to do so.
> > Not sure what the best approach would be though. There's no obvious
> > :-moz-anonymous-content/:-moz-xbl-generated I can see on MDN that I could
> > :not().
>
> Does switching these rules to rem instead of em work? (Might not, but worth
> a shot)
It does not.
|
|
||
Comment 9•10 years ago
|
||
De-listing from the hard-blocker list as this is a pretty small corner case and doesn't prohibit usage.
No longer blocks: ship-incontent-prefs
|
|
||
Updated•10 years ago
|
Whiteboard: [sf-hackweek]
|
|
||
Updated•10 years ago
|
Points: --- → 3
Priority: -- → P4
|
|
||
Comment 11•9 years ago
|
||
This should have been fixed by bug 1247214. Katie, can you confirm?
Flags: needinfo?(kbroida)
|
||
Comment 12•9 years ago
|
||
Confirmed! We resolved this font issue in bug 1247214 by preventing the context menu from inheriting the dialog box's styling.
Flags: needinfo?(kbroida)
|
|
||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•