Closed Bug 1117167 Opened 10 years ago Closed 10 years ago

Generate WebIDL bindings for JS-implemented interfaces against nsIGlobalObject rather than nsPIDOMWindow

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla37

People

(Reporter: mt, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

Make the generated implementation classes for JS-implemented bindings store an nsIGlobalObject, not an nsPIDOMWindow, so we can use them in sandboxes
(deleted), patch
peterv
: review+
Details | Diff | Splinter Review 
WebIDL generated code can't be instantiated outside of a window context because it has a hard dependency on nsPIDOMWindow.  With bug 1117162, that should be less necessary and the code can instead depend on nsIGlobalObject.

There are a few places in Codegen.py that can be switched over easily, then there are several places in the rest of the tree that rely on calling the binding code directly with an nsPIDOMWindow.  The ones I've seen just need a simple substitution.
http://dxr.mozilla.org/mozilla-central/source/dom/bindings/Codegen.py#13547
Summary: Generate WebIDL bindings against nsIGlobalObject rather than nsPIDOMWindow → Generate WebIDL bindings for JS-implemented interfaces against nsIGlobalObject rather than nsPIDOMWindow
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #8543349 - Flags: review?(peterv) → review+
https://hg.mozilla.org/mozilla-central/rev/23ce8a6e826f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: