cppcheck says this: > security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp:113: error: Uninitialized variable: ret This is caused by the block-scoped |ret| overshadowing the function-scoped |ret|. It's not a problem in practice because the one place that calls this function doesn't look at the return value. Still, probably worth fixing to avoid possible future problems.

Comment on attachment 8543733 [details] [diff] [review] Fix shadowed variable in SandboxBroker::SetSecurityLevelForContentProcess() Review of attachment 8543733 [details] [diff] [review]: ----------------------------------------------------------------- Whoops - thanks for fixing this. Doing something when something goes wrong with the sandbox policy setup is on my list of things to look at. :-)

In IRC, njn said this isn't a security bug.