Closed
Bug 1117623
Opened 10 years ago
Closed 10 years ago
Undefined value error in TouchInputMapper::configureSurface()
Categories
(Core :: Widget, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mwu
:
review+
|
Details | Diff | Splinter Review |
cppcheck says:
> widget/gonk/libui/InputReader.cpp:3030: error: Uninitialized variable: deviceModeChanged
It's correct.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8543752 -
Flags: review?(mwu)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8543752 [details] [diff] [review]
Fix undefined value error in TouchInputMapper::configureSurface()
Review of attachment 8543752 [details] [diff] [review]:
-----------------------------------------------------------------
Looks like this was fixed in lollipop. http://androidxref.com/5.0.0_r2/xref/frameworks/native/services/inputflinger/InputReader.cpp#3057
Attachment #8543752 -
Flags: review?(mwu) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
I'll tweak it to be identical to the Lollipop code. Thank you for the review.
Flags: needinfo?(mwu)
|
|
Assignee | |
Comment 5•10 years ago
|
||
|
||
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•