Closed
Bug 1117735
Opened 10 years ago
Closed 10 years ago
Remove PJS test cases
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: lth, Assigned: lth)
References
Details
Attachments
(4 files)
(deleted),
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
Most test cases test for getBuildConfiguration().parallelJS.
Some test for this.hasOwnProperty("TypedObject") and then assumes that TO arrays will have a mapPar method; this is wrong.
We should also remove utility code used by the test cases.
Assignee | ||
Comment 1•10 years ago
|
||
Additionally:
- older tests (which have not been run for a long time) compare "typeof ParallelArray" to undefined.
- some test cases mix parallel and non-parallel tests and must be edited suitably.
Assignee | ||
Comment 2•10 years ago
|
||
Additionally, Array.prototype.build is not ES6 and is only defined in SpiderMonkey when PJS is enabled. Some test cases test for this by testing for TypedObject though (different pattern than listed above).
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8543952 -
Flags: review?(shu)
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8543953 -
Flags: review?(shu)
Updated•10 years ago
|
Attachment #8543952 -
Flags: review?(shu) → review+
Updated•10 years ago
|
Attachment #8543953 -
Flags: review?(shu) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Said bug is the assumption that TypedObject implies Array.build is available.
Attachment #8544601 -
Flags: review?(shu)
Assignee | ||
Comment 6•10 years ago
|
||
Try run of these with preceding and subsequent patches:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=bc950f7b6012
Updated•10 years ago
|
Attachment #8544601 -
Flags: review?(shu) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Assignee | ||
Comment 8•10 years ago
|
||
Assignee | ||
Comment 9•10 years ago
|
||
(In reply to Lars T Hansen [:lth] from comment #8)
> Created attachment 8545099 [details] [diff] [review]
> Edit the names of expected array methods in an xpconnect test. r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/0776988aacd6
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f81514af1687
https://hg.mozilla.org/mozilla-central/rev/2e50b9cf0432
https://hg.mozilla.org/mozilla-central/rev/097840bded9c
https://hg.mozilla.org/mozilla-central/rev/0776988aacd6
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•