This isn't a big deal for correctness right now the way things are written, but currently the runnable is executed for both sync and async init, which isn't future proof (and isn't actually needed in the sync case, so it's a waste of time to execute it).

Comment on attachment 8544272 [details] [diff] [review] Don't set launch runnable unless we're starting async Review of attachment 8544272 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/plugins/ipc/PluginModuleParent.cpp @@ +366,5 @@ > { > PLUGIN_LOG_DEBUG_FUNCTION; > > nsAutoPtr<PluginModuleChromeParent> parent(new PluginModuleChromeParent(aFilePath, aPluginId)); > + UniquePtr<LaunchCompleteTask> onLaunchedRunnable; can we name this something different, it really threw me at first since it looks like some sort of 'onXYZ' event method. Maybe just 'launchRunnable'?

Addressed comment. Carrying forward r+.

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/8fa274cce616 for various test failures: https://treeherder.mozilla.org/logviewer.html#?job_id=5181302&repo=mozilla-inbound https://treeherder.mozilla.org/logviewer.html#?job_id=5182176&repo=mozilla-inbound https://treeherder.mozilla.org/logviewer.html#?job_id=5181308&repo=mozilla-inbound

On further inspection of this code, I think that it should be left as-is. My bad.