Closed
Bug 1117984
Opened 10 years ago
Closed 9 years ago
Should wait for 200 response before writing in nr_socket_proxy_tunnel_write
Categories
(Core :: WebRTC: Networking, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
| backlog | webrtc/webaudio+ |
People
(Reporter: ryan, Assigned: drno)
References
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141126041045
Steps to reproduce:
Write immediately after sending HTTP CONNECT
Expected results:
After sending CONNECT return R_WOULDBLOCK until connect_received && !connect_failed
|
||
Updated•10 years ago
|
Product: Firefox → Core
|
||
Comment 1•9 years ago
|
||
Hi,
This problem was fixed in version 38, if you still have this issue please let us know.
Component: Untriaged → WebRTC: Networking
Flags: needinfo?(ryan)
|
Assignee | |
Comment 2•9 years ago
|
||
The bug is real and still alive: https://dxr.mozilla.org/mozilla-central/source/media/mtransport/third_party/nICEr/src/net/nr_proxy_tunnel.c#329
Status: UNCONFIRMED → NEW
backlog: --- → webrtc/webaudio+
Rank: 35
Ever confirmed: true
Flags: needinfo?(ryan)
OS: Mac OS X → All
Priority: -- → P3
Hardware: x86 → All
|
|
Assignee | |
Comment 3•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/31877/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31877/
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8710814 -
Flags: review?(docfaraday)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → drno
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8710814 -
Attachment description: MozReview Request: Bug 1117984: added proxy connection state enum → MozReview Request: Bug 1117984: added proxy connection state enum. r=bwc
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8710814 [details]
MozReview Request: Bug 1117984: added proxy connection state enum. r=bwc
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31877/diff/1-2/
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8710814 [details]
MozReview Request: Bug 1117984: added proxy connection state enum. r=bwc
https://reviewboard.mozilla.org/r/31877/#review28675
::: media/mtransport/third_party/nICEr/src/stun/nr_socket_buffered_stun.c:527
(Diff revision 2)
> + if (sock->read_state == NR_ICE_SOCKET_READ_FAILED) {
This was confusing because NR_ICE_SOCKET_READ_FAILED is a misnomer, since it is also used when there are write failures. We should probably clean this up, but in a separate ticket.
Attachment #8710814 -
Flags: review?(docfaraday) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
Comment on attachment 8710814 [details]
MozReview Request: Bug 1117984: added proxy connection state enum. r=bwc
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31877/diff/2-3/
|
||
Comment 8•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•