What this bug will not cover removing: - The ParallelExecution ExecutionMode - ForkJoin (incl. simplifying the Context hierarchy) - VM functions that had extra paths added - GC functions that had extra paths added

Have fun.

Oops, forgot about the other architectures.

Comment on attachment 8544284 [details] [diff] [review] Remove JIT parts of PJS. Review of attachment 8544284 [details] [diff] [review]: ----------------------------------------------------------------- Massive, but thankfully largely mechanical in nature. Nits: Something left undone here? --- a/js/src/vm/ForkJoin.cpp +++ b/js/src/vm/ForkJoin.cpp @@ -809,26 +809,19 @@ ForkJoinOperation::appendCallTargetsToWorklist(uint32_t index, ExecutionStatus * + // TODOshu remove Function CanEnterInParallel can be removed now if the single call to it in ForkJoin.cpp is removed: diff --git a/js/src/jit/Ion.cpp b/js/src/jit/Ion.cpp @@ -2350,68 +2252,30 @@ jit::CompileFunctionForBaseline(JSContext *cx, HandleScript script, BaselineFram MethodStatus jit::CanEnterInParallel(JSContext *cx, HandleScript script) { ... - return Method_Compiled; + return Method_Error;

(In reply to Lars T Hansen [:lth] from comment #3) > Comment on attachment 8544284 [details] [diff] [review] > Remove JIT parts of PJS. > > Review of attachment 8544284 [details] [diff] [review]: > ----------------------------------------------------------------- > > Massive, but thankfully largely mechanical in nature. Nits: > > Something left undone here? > > --- a/js/src/vm/ForkJoin.cpp > +++ b/js/src/vm/ForkJoin.cpp > @@ -809,26 +809,19 @@ > ForkJoinOperation::appendCallTargetsToWorklist(uint32_t index, > ExecutionStatus * > + // TODOshu remove > > > Function CanEnterInParallel can be removed now if the single call to it in > ForkJoin.cpp is removed: > > diff --git a/js/src/jit/Ion.cpp b/js/src/jit/Ion.cpp > @@ -2350,68 +2252,30 @@ jit::CompileFunctionForBaseline(JSContext *cx, > HandleScript script, BaselineFram > MethodStatus > jit::CanEnterInParallel(JSContext *cx, HandleScript script) > { > ... > - return Method_Compiled; > + return Method_Error; I wanted to avoid touching the vm/ stuff too much, but it's probably not too bad in this case to just remove the call in ForkJoin.cpp

Appears to have landed on m-i: changeset: 222596:7584b643e7e9 user: Shu-yu Guo <shu@rfrn.org> date: Wed Jan 07 01:18:42 2015 -0800 summary: Bug 1118038 - Remove JIT parts of PJS. (r=lth)