Peter Bylenga [:PBylenga] Reporter
	Description • 10 years ago

In Bug 1117981, allowing screen to timeout and then unlocking showed an unexpected earlier time on lockscreen.

	Martijn Wargers (dead)
	Comment 1 • 10 years ago

I think No-Jun actually already has something like the beginning of a gaia-ui test in bug 1116672 for this.

	Martijn Wargers (dead)
	Comment 2 • 10 years ago

Assigning this to No-Jun in the light of comment 1.

	No-Jun Park [:njpark] Assignee
	Comment 3 • 10 years ago

oh, I have this already in my imagecompare branch. I'll create a new branch for it and submit a pull request.

	No-Jun Park [:njpark] Assignee
	Comment 6 • 10 years ago

Comment on attachment 8548709 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27369

I'm pretty sure I'll get a plenty of feedback for my approach here.  Could you see whether my test case steps are effective?  Also, it seems that it takes about 8 minutes to reach line 32 in B2G desktop, so i only check it up to '12:3'

	Johan Lorenzo [:jlorenzo] - On PTO, back on September 11th
	Comment 7 • 10 years ago

Comment on attachment 8548709 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27369

The test fails on my b2g desktop as well as on Treeherder[1]. I think we could change the time like a user would do or waiting until the change appears on the lockscreen.

[1] https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=4e45e90041ad

	No-Jun Park [:njpark] Assignee
	Comment 8 • 10 years ago

So I found bug 1122503 while writing tests, and I think we need to wait until this bug is fixed.

	No-Jun Park [:njpark] Assignee
	Comment 9 • 9 years ago

I made some changes here, and it's consistently passing on my machine. but I can't get the try server to pick up my change, (even when I open/close pull request) has something changed?

	Johan Lorenzo [:jlorenzo] - On PTO, back on September 11th
	Comment 10 • 9 years ago

Comment on attachment 8562500 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27369

A couple of minor issues, the big one to me is when we do an action or not depending on the state of the UI. This can lead to false positive results. More details in the PR.

	Martijn Wargers (dead)
	Comment 11 • 9 years ago

Comment on attachment 8562500 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27369

Just some minor issue, but since jlorenzo already r--ed it, I'll wait for your updated pull request.

	No-Jun Park [:njpark] Assignee
	Comment 12 • 9 years ago

Comment on attachment 8562500 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27369

Made changes based on the comments, and squashed commits.  retrying for review.

	Martijn Wargers (dead)
	Comment 13 • 9 years ago

Comment on attachment 8562500 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27369

Some minor nits, and some comments, which you need to act upon or provide feedback why you disagree with, then this is r+ from me.
I tested it locally on my device and it ran at 11 times without failure.

	Johan Lorenzo [:jlorenzo] - On PTO, back on September 11th
	Comment 14 • 9 years ago

Comment on attachment 8562500 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27369

Looks good to me. Runs on my device and test_settings_change_time_format.py is not broken by the change you made.

	No-Jun Park [:njpark] Assignee
	Comment 15 • 9 years ago

It is merged in gaia:
https://github.com/mozilla-b2g/gaia/commit/fade7b7ec93cbd866279f20eb3960779cccf385f