Closed
Bug 1118103
Opened 10 years ago
Closed 9 years ago
swap the aliasing direction of -moz-margin-start <-> margin-inline-start etc.
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
References
(Blocks 2 open bugs)
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(1 file)
(deleted),
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
At the same time we land a patch in bug 1099032 that turns the vertical text pref on, we should make margin-inline-start the real property and -moz-margin-start the alias, etc.
Updated•10 years ago
|
Keywords: dev-doc-needed
Updated•10 years ago
|
Assignee | ||
Updated•9 years ago
|
Blocks: enable-writing-mode-release
Assignee | ||
Updated•9 years ago
|
No longer blocks: enable-writing-mode-release
Depends on: enable-writing-mode-release
Assignee | ||
Comment 3•9 years ago
|
||
We actually can only do this once we remove the pref, not just flip its default value.
Comment 4•9 years ago
|
||
I think we should do it sooner than that; we can just pull the necessary properties out from behind the pref -- such that if we want to turn the pref off, we'd need to back out a (small-ish) patch.
Assignee | ||
Comment 5•9 years ago
|
||
OK, fair enough. The patch won't be tiny, but if we need to back it out it won't be impossible.
Assignee: nobody → cam
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•9 years ago
|
||
Attachment #8629194 -
Flags: review?(dbaron)
Updated•9 years ago
|
Attachment #8629194 -
Flags: review?(dbaron) → review+
Comment 8•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Comment 9•9 years ago
|
||
I've added dev-doc-need long time ago, but I wonder if this has an effect on Web Devs. We are only swapping properties and their alias. Am I right?
Flags: needinfo?(cam)
Comment 10•9 years ago
|
||
It affects serialization of style rules (e.g., element.style.cssText) and iteration of the properties in a style rule, since those show the canonical form rather than the alias.
Flags: needinfo?(cam)
Comment 11•9 years ago
|
||
Thanks.
The old pages (-moz-*) now redirect to the new ones.
Also added a comment in https://developer.mozilla.org/en-US/Firefox/Releases/42#CSS
Keywords: dev-doc-needed → dev-doc-complete
Comment 12•9 years ago
|
||
Added the site compatibility doc as well: https://www.fxsitecompat.com/en-US/docs/2015/cssrule-csstext-now-returns-unprefixed-writing-mode-aware-properties/
Updated•9 years ago
|
Keywords: site-compat
Comment 13•9 years ago
|
||
On Firefox 41, the Page Inspector was also showing the prefixed properties rather than unprefixed ones. I was confused myself while working on Bug 1208123. Will update the compat doc ;)
You need to log in
before you can comment on or make changes to this bug.
Description
•