The server looks for the property "session_id" on the Command object in newSession. According to the WebDriver protocol it should be "sessionId".

Hi, I like to work on this bug. Could you tell me the file where I need to make the change?

Redirecting question to bug mentor.

We need to update https://dxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-server.js#606 to check both session_id or sessionId to maintain backwards compatibility

David, could you check it and tell me if it's ok? Thanks

Comment on attachment 8568769 [details] [diff] [review] 1118313.patch Review of attachment 8568769 [details] [diff] [review]: ----------------------------------------------------------------- ::: testing/marionette/marionette-server.js @@ +602,5 @@ > } > > this.scriptTimeout = 10000; > if (aRequest && aRequest.parameters) { > + this.sessionId = aRequest.parameters.session_id || aRequest.parameters.session_id || null; one of these should be sessionId

Patch v2

Sorry was my fault

Comment on attachment 8570972 [details] [diff] [review] 1118313.patch Review of attachment 8570972 [details] [diff] [review]: ----------------------------------------------------------------- sorry this took so long to review, I have an attention span of a goldfish and kept starting and not finishing the review :/ ::: testing/marionette/marionette-server.js @@ +602,5 @@ > } > > this.scriptTimeout = 10000; > if (aRequest && aRequest.parameters) { > + this.sessionId = aRequest.parameters.session_id || aRequest.parameters.sessionId || null; I would prefer this since if it doesnt hit either of them it will be undefined and the null check below would still work this.sessionId = aRequest.parameters.sessionId ? aRequest.parameters.sessionId : aRequest.parameters.session_id ;

Patch v3

Please let me know if this is what you suggest my or I misunderstand your feedback. Thanks

Perfect! THanks! Please have a look at https://wiki.mozilla.org/Auto-tools/Projects/Marionette/Auto-tools/Projects/Marionette/Roadmap#Good_First_Bugs if there are any other good first bugs you would like to tackle!

This needs rebasing, sorry.

Sorry I forget this issue. I attach a rebased version of the patch.