Closed
Bug 1118614
Opened 10 years ago
Closed 10 years ago
Remove redundant test/context-menu/utils openWindow and closeWindow functions
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evold, Assigned: evold)
References
Details
Attachments
(1 file)
The test/context-menu/utils openWindow and closeWindow functions can be replaced by those in sdk/window/helpers
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8545021 -
Flags: review?(rFobic)
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → evold
Comment 2•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/ad496a0e1928b56bb9438c95f8d5f34dfd0995d8
Bug 1118614 - Remove redundant test/context-menu/utils openWindow and closeWindow functions
https://github.com/mozilla/addon-sdk/commit/2e521be8a958d74f9be12ca74b8ca87ce0dea7f8
Merge pull request #1812 from erikvold/1118614
Bug 1118614 - Remove redundant test/context-menu/utils openWindow and closeWindow functions r=@gozala
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8545021 [details]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1812
From Irakli at https://github.com/mozilla/addon-sdk/pull/1812#issuecomment-69096376
"@erikvold please do not change test/test-context-menu@2.js it does not seems to be necessary. With changes to only test/context-menu/util it's r+. If changes to other file are necessary please ping me to explain why."
which is now done.
Attachment #8545021 -
Flags: review?(rFobic) → review+
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•