Closed
Bug 1118884
Opened 10 years ago
Closed 10 years ago
[RTL][Cost Control] The date on the System's page is being cutoff on the right side of the screen
Categories
(Firefox OS Graveyard :: Gaia::Cost Control, defect, P1)
Tracking
(feature-b2g:2.2+, b2g-v2.2 verified, b2g-master verified)
People
(Reporter: KTucker, Assigned: autra)
References
Details
(Whiteboard: [NaBfT])
Attachments
(2 files)
(deleted),
image/jpeg
|
Details | |
(deleted),
text/x-github-pull-request
|
mai
:
review+
bajaj
:
approval-gaia-v2.2+
|
Details |
Description:
The date on the System's page is being cutoff on the right side of the screen.
Repro Steps:
1) Updated Flame to Build ID: 20150107010216
2) Change the language to "Arabic" in settings.
3) Tap on the "Usage" app.
4) Proceed through the setup until reaching the "Usage" page.
5) Tap on "System" under "Mobile App Usage".
6) Observe the month "Feb" to the right of the screen under the data graph.
Actual:
The month "Feb" is being cutoff on the right side of the screen.
Expected:
The abbreviation "Feb" is not cutoff under System.
Environmental Variables
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
Build ID: 20150107010216
Gecko: https://hg.mozilla.org/mozilla-central/rev/33781a3a5201
Gaia: 69ac77cfa938fae2763ac426a80ca6e5feb6ad25
Platform Version: 37.0a1
Firmware Version: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Notes:
Repro frequency: 5/5 100%
See attached: screenshot
Reporter | ||
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage?][rtl-impact]
Flags: needinfo?(pbylenga)
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage?][rtl-impact] → [QAnalyst-Triage+][rtl-impact]
Flags: needinfo?(pbylenga)
Updated•10 years ago
|
Whiteboard: [NaBfT]
Updated•10 years ago
|
Priority: -- → P1
Updated•10 years ago
|
feature-b2g: --- → 2.2+
Updated•10 years ago
|
Assignee: nobody → augustin.trancart
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8558627 -
Flags: review?(salva)
Comment 2•10 years ago
|
||
Comment on attachment 8558627 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27884
Marina, could you review this bug, please? Thank you!
Attachment #8558627 -
Flags: review?(salva) → review?(marina.rodrigueziglesias)
Comment 3•10 years ago
|
||
Comment on attachment 8558627 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27884
LGTM. Thanks!
Attachment #8558627 -
Flags: review?(marina.rodrigueziglesias) → review+
Assignee | ||
Updated•10 years ago
|
blocking-b2g: --- → 2.2?
Comment 4•10 years ago
|
||
Removing blocking flag as it's not needed for RTL bugs.
Please ask for approval for 2.2
blocking-b2g: 2.2? → ---
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8558627 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27884
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Lack of RTL support
[User impact] if declined: In RTL language the date on the cost control string can't be entirely read
[Testing completed]: On flame 2.2
[Risk to taking this patch] (and alternatives if risky): Moderate, only trivial change to canvas alignment.
[String changes made]: None
Attachment #8558627 -
Flags: approval-gaia-v2.2?(francisco)
Comment 6•10 years ago
|
||
Marina, can we land this on master & resolve it?
Flags: needinfo?(marina.rodrigueziglesias)
Comment 7•10 years ago
|
||
yes, you can land the patch on master.
Flags: needinfo?(marina.rodrigueziglesias)
Comment 8•10 years ago
|
||
waiting for master landing here before getting this on the branch.
Comment 9•10 years ago
|
||
Master: 63d943d4e36b281679ada4d826f2cf96c7e7f474
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
status-b2g-master:
--- → fixed
Updated•10 years ago
|
Attachment #8558627 -
Flags: approval-gaia-v2.2?(francisco) → approval-gaia-v2.2+
Comment 10•10 years ago
|
||
Target Milestone: --- → 2.2 S6 (20feb)
Comment 11•10 years ago
|
||
Hi KTucker,
What should we do will make the System displayed?
I made a lot of operation, but most of them were classed as Others or the AP's name(Email/Homescreen/Smart Collections).
Flags: needinfo?(ktucker)
Reporter | ||
Comment 12•10 years ago
|
||
Adding Shing to see if he can answer or find someone who can answer the question in comment 11
Flags: needinfo?(ktucker) → needinfo?(slyu)
Comment 13•10 years ago
|
||
This issue reproduces on today's Flame 2.2 nightly build.
Result: The keyboard disappears after entering a letter in the rocket bar.
Result: Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150223002503
Gaia: 389542b71c89253c0d176d3b0bfb54e275c19bf1
Gecko: 9fd3441c8983
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Comment 14•10 years ago
|
||
(In reply to Yeojin Chung [:YeojinC] from comment #13)
> This issue reproduces on today's Flame 2.2 nightly build.
>
> Result: The keyboard disappears after entering a letter in the rocket bar.
>
> Result: Device: Flame 2.2 (KK, 319mb, full flash)
> Build ID: 20150223002503
> Gaia: 389542b71c89253c0d176d3b0bfb54e275c19bf1
> Gecko: 9fd3441c8983
> Gonk: e7c90613521145db090dd24147afd5ceb5703190
> Version: 37.0a2 (2.2)
> Firmware Version: v18D-1
> User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Please ignore this comment. I was working on a different bug. Sorry about the mess.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Comment 15•10 years ago
|
||
This issue is verified fixed on Flame Master and 2.2.
Result: The month is not cut off from the screen under mobile usage per app screen.
Device: Flame Master (KK, 319mb, full flash)
Build ID: 20150223010224
Gaia: a6881205deae450757a8d1e1ed65e5e5be0ec633
Gecko: 86d2bb8bb1c9
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150223002503
Gaia: 389542b71c89253c0d176d3b0bfb54e275c19bf1
Gecko: 9fd3441c8983
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+][rtl-impact] → [QAnalyst-Triage?][rtl-impact]
Flags: needinfo?(ktucker)
Reporter | ||
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage?][rtl-impact] → [QAnalyst-Triage+][rtl-impact]
Flags: needinfo?(ktucker)
Comment 16•10 years ago
|
||
(In reply to SandKing from comment #11)
The "System" category was renamed to "Others" in bug 1125791
> Hi KTucker,
> What should we do will make the System displayed?
> I made a lot of operation, but most of them were classed as Others or the
> AP's name(Email/Homescreen/Smart Collections).
Flags: needinfo?(slyu)
You need to log in
before you can comment on or make changes to this bug.
Description
•