Closed Bug 1119 Opened 26 years ago Closed 26 years ago

List items not indented

Categories

(Core :: Layout, defect, P2)

x86
Windows 95
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: dbaron, Assigned: buster)

References

()

Details

The list items in the URL above aren't indented. The problem started sometime between the 10-8 build and the 10-15 build. It may have to do with the CSS in the linked stylesheet, which thoroughly goes through anything that could indent a list, and sets all but one of these properties (margin-left on UL) to 0.‰
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Thanks for the bug report; now the layout code is more flexible as I use the bullets right-margin to place it properly and since that value comes from ua.css it's more controllable.
Do you mean that something was fixed today? (I assume you meant left-margin.) The left-margin on the UL in the URL *is* nonzero (if it were zero than the behavior would be correct, although that's not the way Nav4 treated it, which I think is what you are referring to). It's just everything else is set to zero, so the margin-left should indent, but only by the amount of that margin. (The reason that I do that is that CSS does not specify where the default indenting in a list lies, so it can lie anywhere, so if I want to set it to something, I have to set it in one place and set everything else to zero. This is needed, because you split it between margin and padding, so if I want to set margin to be the indent, I need to set padding to zero.) I'm not reopening the bug because I'm not sure if I misunderstood your comments and there was a bug fixed today, or not, but if there was no fix then the bug should be reopened. ‰
I fixed it today, so if you build it you can pull it and get the fix; otherwise pick up tommorows build and try it out. Regarding the style issue: we use a pseudo-style, :BULLET, to define what style to apply to bullets. This is outside the scope of CSS, but it means that its definiable in the style sheet. What I did was to remove hard coded bullet adjustment values (which were based on the LI's padding/2) and instead use the value directly out of the ua.css style sheet. Sorry for the confusion
verified fixed in dev release builds
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.