The glass icon introduced in bug 1088660 is the same icon used for all platforms, but doesn't fit very well. For example on Mac the icon turns dark gray on hover and black when clicked, but the go icon in the same searchbox turns blue when clicked. The (+) badge added in bug 1106432 could probably also fit better if it had platform specific variations. Gavin told me it's a bit too visible; maybe it should be less obvious and become colored only on hover? I think Stephen had a note somewhere to take care of making these icons fit better in our various themes, but I don't think a bug had been filed.

See also bug 1116009 comment 6 about the (+) badge looking out of place.

The only platform specific change needed is making the direction of magnifying glass consistent with the Windows system magnifying glass. Linux and OS X stay the same. We can probably use the same icon for incontent prefs and just flip it with a transform?

(In reply to Stephen Horlander [:shorlander] from comment #3) > We can probably use the same icon for incontent prefs and just flip it with > a transform? Seems doable yes :). (In reply to Florian Quèze [:florian] [:flo] from comment #0) > For example on Mac the icon turns dark gray on hover and black when clicked, > but the go icon in the same searchbox turns blue when clicked. Is this color inconsistency something we don't want to fix?

(In reply to Florian Quèze [:florian] [:flo] from comment #4) > Is this color inconsistency something we don't want to fix? They are mostly inconsistent because they were done at various times. They need to be unified, but that requires updating the old stuff and not the new stuff. So in other words, yes, but not in this bug :)

Do we also need versions for the Developer Edition dark theme? https://www.dropbox.com/s/x74rnrfs0yin5q5/Screenshot%202015-01-27%2011.17.07.png?dl=0 seems kind of bright to my untrained eye…

(In reply to Stephen Horlander [:shorlander] from comment #5) > (In reply to Florian Quèze [:florian] [:flo] from comment #4) > > Is this color inconsistency something we don't want to fix? > > They are mostly inconsistent because they were done at various times. They > need to be unified, but that requires updating the old stuff and not the new > stuff. So in other words, yes, but not in this bug :) Do you mean you want to get rid of the blue color everywhere?

(In reply to Florian Quèze [:florian] [:flo] from comment #7) > (In reply to Stephen Horlander [:shorlander] from comment #5) > > (In reply to Florian Quèze [:florian] [:flo] from comment #4) > > > Is this color inconsistency something we don't want to fix? > > > > They are mostly inconsistent because they were done at various times. They > > need to be unified, but that requires updating the old stuff and not the new > > stuff. So in other words, yes, but not in this bug :) > > Do you mean you want to get rid of the blue color everywhere? Probably. We have been moving towards using a tints and shades for various states. Still need to finalize how that works for all of the various bits we have in the location bar and the search bar.

Florian, do you konw if there is there a separate bug that is tracking landing these new icons?

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #9) > Florian, do you konw if there is there a separate bug that is tracking > landing these new icons? I think we need to file a new one.

(In reply to Florian Quèze [:florian] [:flo] from comment #10) > (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #9) > > Florian, do you konw if there is there a separate bug that is tracking > > landing these new icons? > > I think we need to file a new one. Ok, I filed bug 1126527 to track this.