Closed
Bug 1119302
Opened 10 years ago
Closed 10 years ago
Implement nsIContentPolicy.shouldProcess for plugin resource loads
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(firefox36 fixed, firefox37 fixed)
RESOLVED
FIXED
mozilla37
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
bzbarsky
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details |
Plugin resource loads currently don't use nsIContentPolicy.shouldProcess, which means that we don't have MIME type data for them. This patch fixes that and is necessary for the experiment in bug 1108668.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → benjamin
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8546021 -
Flags: review?(bzbarsky)
Comment 2•10 years ago
|
||
Comment on attachment 8546021 [details]
Reviewboard request
r+, but please see the reviewboard comments. I wish it actually set the r+ state here instead of putting me through the extra work... filed bug 1119416.
Attachment #8546021 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8546021 [details]
Reviewboard request
Approval Request Comment
[Feature/regressing bug #]: API needed for the experiment in bug 1108668
[User impact if declined]: Can't run the experiment
[Describe test coverage new/current, TBPL]: Manually verified with the experiment code
[Risks and why]: There is a risk that nsIContentPolicy implementations will see new notifications that they didn't expect and will somehow fail. I judge this risk as fairly low, and is mainly a risk with addons.
[String/UUID change made/needed]: None
Attachment #8546021 -
Flags: approval-mozilla-aurora?
Backed out for failures in test_streamNotify.html:
https://treeherder.mozilla.org/logviewer.html#?job_id=5277932&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=5278924&repo=mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/157873c02e6d
Flags: needinfo?(benjamin)
This also failed with this patch:
https://treeherder.mozilla.org/logviewer.html#?job_id=5280947&repo=mozilla-inbound
Updated•10 years ago
|
status-firefox36:
--- → affected
status-firefox37:
--- → affected
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/621fadc8702b I had to move the code later in the method so that error returns triggered notifications properly.
Flags: needinfo?(benjamin)
Comment 8•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment 9•10 years ago
|
||
Comment on attachment 8546021 [details]
Reviewboard request
[Triage Comment]
After the merge.
Attachment #8546021 -
Flags: approval-mozilla-beta+
Attachment #8546021 -
Flags: approval-mozilla-aurora?
Attachment #8546021 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 10•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/c447c4b139a9 (this made 37 before the merge)
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•