Mike Kaply [:mkaply] Reporter
	Description • 10 years ago

Currently the PageActions add API takes one icon parameter. It's up to the caller to determine the proper icon to pass to the API based on the screen resolution.

We should allow multiple sizes to be passed, like:

icon64: '64.png", icon128: "icon128.png", etc. and then the PageActions jsm would use the proper icon.

See:

https://github.com/leibovic/fennec_rss/blob/master/bootstrap.js#L344

for examples.

	Mike Kaply [:mkaply] Reporter
	Comment 1 • 10 years ago

Also see:

https://bugzilla.mozilla.org/show_bug.cgi?id=993698

	Nick Alexander :nalexander [he/him] (PTO until Montreallhands August 21, 2023)
	Comment 2 • 10 years ago

We're just begging for a more uniform way to expose multiple icon sizes/densities across all of our JSM APIs.

	Mike Kaply [:mkaply] Reporter
	Comment 3 • 10 years ago

See chrome's implementation as well:

https://developer.chrome.com/extensions/manifest/icons

	:Margaret Leibovic
	Comment 4 • 8 years ago

Does this fit into the web extensions work?

	Matthew Wein [:mattw]
	Comment 5 • 8 years ago

Yes it does, thanks!

	Matthew Wein [:mattw]
	Comment 6 • 8 years ago

Once bug 1270742 lands, we'll be able to use ExtensionUtils.jsm to do this. 

I'm moving the relevant code that desktop uses (found in ext-utils.js) into ExtensionUtils.jsm, and then making some additions/modifications so Android can also use it. This is the code for how I'm using IconDetails with PageActions.jsm in ext-pageAction.js:
  
  this.icons = IconDetails.normalize({path: options.default_icon}, extension);
  
  ...  

  let {icon} = IconDetails.getURL(this.icons, context.contentWindow, this.extension, 18);
  let browserWindow = Services.wm.getMostRecentWindow("navigator:browser");
  return IconDetails.convertImageURLToDataURL(icon, context, browserWindow).then(dataURI => {
     let options = {
        icon = dataURI,
        ...
     }
     let id = PageActions.add(this.options);
     
     ...
    }
  });

Let me know if you have any questions.  I think we can close this bug once bug 1270742 lands.

	Matthew Wein [:mattw]
	Comment 7 • 8 years ago

I meant to undo marking this bug as a duplicate before submitting my commit but I forgot to.  If there aren't any objections, however, I'm going to leave it marked that way.