Comment on attachment 8547022 [details] [diff] [review] drop-shadow.txt Review of attachment 8547022 [details] [diff] [review]: ----------------------------------------------------------------- I tested it on Windows and it looks the same as it did before. I'll grant r+ for this but I'm curious about the fill:black; difference between Windows and OSX. By the way, Linux uses the Windows file in case you were wondering. ::: toolkit/themes/osx/global/media/videoClickToPlayButton.svg @@ +45,5 @@ > width="1.25" > height="1.25" > color-interpolation-filters="sRGB" > id="dropShadow"> > + <feDropShadow dx="0" dy="1" flood-opacity="0.5" /> nit, please remove the space between the last double-quote and the closing slash to keep the two files for themes/osx and themes/windows binary equal. ::: toolkit/themes/windows/global/media/videoClickToPlayButton.svg @@ +58,5 @@ > <path > d="M32,4C16.536,4,4,16.536,4,32s12.536,28,28,28s28-12.536,28-28S47.464,4,32,4z M47.285,33.014 L23.75,46.762C22.797,47.319,22,46.863,22,45.751v-27.5c0-0.697,0.32-1.137,0.781-1.232c0.277-0.058,0.612,0.012,0.969,0.221 l23.535,13.751C48.238,31.546,48.238,32.458,47.285,33.014z" > mask="url(#dropShadowMask)" > id="playButtonShadow" > + style="fill:black;filter:url(#dropShadow)" /> The osx version doesn't have the fill:black; here. Which one is correct? Also, please add a semicolon to the end of this style and also to the end of the styles in the osx version to keep these files binary equal.

The default value for fill is black (http://www.w3.org/TR/SVG/painting.html#FillProperties) so it can and should be removed. I just forgot to remove it from one of the files.