Closed Bug 1120131 Opened 10 years ago Closed 10 years ago

Improve the behavior when joining to an expired Room

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: oteo, Assigned: crdlc)

References

Details

Attachments

(1 file)

(deleted), text/x-github-pull-request
borjasalguero
: review+
Details
After implementing Bug 1115014 - Improve the behavior when joining to a deleted Room, we realized that we should offer to the user a similar feedback when he tries to join a created or invited room already expired. Right now, when the user tries to join, the Room screen is closed and he will be informed with a general message: "Oops! That didn't work as expected. Why don't we give it another try?" that is not clear enough. Monica will provide the exact string but it should be something like:"Oops... You can't join because this room is expired. Do you want to delete it from your room list?" with the options "Cancel" and "Delete". In case option "Delete" is pressed, the room will be deleted (not necessary in this case to show the banner for invited rooms or the confirmation message for created ones) and we go back to the Room list In case "Cancel" is selected, the Room list is shown again but the Room will be updated with "Expired" (in case it was not updated before)
Setting ni to Monica to confirm the exact string and Setting ni to Jose Antonio to confirm that the server is able to Know that the room, we are trying to join, is expired so we can provide to the user with that concrete message.
Flags: needinfo?(monica.meika)
Flags: needinfo?(josea.olivera)
Blocks: 1097684
I started checking this: 1) If you join a room as invited, the expire date is renewed. Same happens when you are the owner 2) I have created a room with expiresIn = 1 hour, so we can know if we will receive errno = 111 and code 4xx
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Flags: needinfo?(josea.olivera)
Attached file Github pull request (deleted) —
Attachment #8547530 - Flags: review?(borja.bugzilla)
As we can not differentiate if a Room has been deleted by the creator or it is has been expired, we are going to provide the same info/message for both cases: "Oops... You can't join because the room is not longer available. It may be expired or deleted. Do you want to delete it from your room list?" In case the user choose not to delete the room, the Room list will be shown again but the Room will be updated with "No longer available" string.
Be aware that in this patch Cristian is already updating the new string for the bug 1115014 - Improve the behavior when joining to a deleted Room that was already landed.
Blocks: 1115014
Comment on attachment 8547530 [details] Github pull request Few comments to address, but easy all of them. Thanks for the patch!
Attachment #8547530 - Flags: review?(borja.bugzilla) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Flags: needinfo?(monica.meika)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: