Closed Bug 1120431 Opened 10 years ago Closed 10 years ago

Position fixed element causing "white-out" of content to its right

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Version:
34 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla38

People

(Reporter: t.lindemann, Assigned: tnikkel)

Details

(Keywords: reproducible, testcase, Whiteboard: [gfx-noted])

Attachments

(6 files)

Bildschirmfoto 2015-01-12 um 16.07.36.png
(deleted), image/png
Details
master.css
(deleted), text/css
Details
Testcase
(deleted), text/html
Details
Screenshot 2015-01-13 12.17.06.png
(deleted), image/png
Details
Covered display item
(deleted), image/png
Details
patch + test
(deleted), patch
mattwoodrow
: review+
Details | Diff | Splinter Review
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:34.0) Gecko/20100101 Firefox/34.0 Build ID: 20141126041045 Steps to reproduce: I oppened the Page https://steidl.de/Kuenstler-0104172350.html Actual results: On OSX 10.10.1 in combination with Firefox 34.0.5 there is a untouchable white Space beside of two unordered lists. The white space covers the text in the center of the page. Is the background color set to #FFF there is no white space anymore. Expected results: I don't want to set the backgroundcolor of these elements. The background color should be transparent.
Also reproducible on Windows (for me) on current Nightly, not reproducible in safe mode... Milan, can you (suggest someone to) take a look? Thorben, as a workaround, setting opacity: 0.98 on the container of the lists (the left .headline-active) seems to work around it without noticeable visual issues.
Status: UNCONFIRMED → NEW
Component: Untriaged → Graphics: Layers
Ever confirmed: true
Flags: needinfo?(milan)
Keywords: reproducible, testcase
OS: Mac OS X → All
Product: Firefox → Core
Hardware: x86 → All
Summary: Untouchable White Space → Position fixed element causing "white-out" of content to its right
Attached file master.css (deleted) —
Attached file Testcase (deleted) —
In case it's relevant, the Windows machine on which I see this has the following graphics info (according to 35): Adapter Description NVIDIA Quadro 600 Adapter Drivers nvd3dumx,nvwgf2umx,nvwgf2umx nvd3dum,nvwgf2um,nvwgf2um Adapter RAM 1024 Device ID 0x0df8 Direct2D Enabled true DirectWrite Enabled true (6.3.9600.17415) Driver Date 8-29-2013 Driver Version 9.18.13.2702 GPU #2 Active false GPU Accelerated Windows 1/1 Direct3D 11 (OMTC) Subsys ID 083510de Vendor ID 0x10de WebGL Renderer Google Inc. -- ANGLE (NVIDIA Quadro 600 Direct3D9Ex vs_3_0 ps_3_0) windowLayerManagerRemote true AzureCanvasBackend direct2d AzureContentBackend direct2d AzureFallbackCanvasBackend cairo AzureSkiaAccelerated 0
Thanks for your fast answer :) The workaround works fine :)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
(In reply to Thorben Lindemann from comment #5) > Thanks for your fast answer :) The workaround works fine :) While I'm glad it works, we still need to fix the bug when using opacity:1. :-)
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Benoit, can you tell if is this on the layout side or graphics?
Flags: needinfo?(milan) → needinfo?(bgirard)
Attached image Screenshot 2015-01-13 12.17.06.png (deleted) —
Easy! We're incorrectly generating an opaque layer for the bounding rect. The layer has display items that are behind it and being masked. We're incorrectly considering the layer to be opaque when it's covering display items in behind it.
Flags: needinfo?(bgirard)
Sending it to :tn first but maybe roc wants to look at this?
Flags: needinfo?(tnikkel)
Attached image Covered display item (deleted) —
Whiteboard: [gfx-noted]
The problem is that we pull up an opaque background color into the layer, but the area we draw this background color over isn't added to the draw region, so then later other items that are above it get placed on the layer below. I have the fix locally: add the visible region to the draw region if we are going to draw a forced background color over the visible region. (We hit a wierd case where the visible and draw region consists of some small regions on the left of the page, and one small region on the right (the actual rect in the region differ by maybe 1 pixel in some dimensions). The visible region gets simplified into one large rect at one point, but the draw region doesn't.)
Assignee: nobody → tnikkel
(In reply to Timothy Nikkel (:tn) from comment #11) > I have the fix locally: add the visible region to the draw region if > we are going to draw a forced background color over the visible region. Actually this isn't a proper fix because by the time we decide if we are drawing a forced background color we are popping the layer and we may have already decided to put items in layers below. I guess we just need to make sure that the draw region is a super set of the visible region (even when region simplication messes that up). Still struggling to write a proper test for this...
Attached patch patch + test (deleted) — — Splinter Review
Finally managed to get a test, needed two reftests: one that tests this bug before the optimization of bug 1099977, one that tests this bug after the optimization of bug 1099977.
Flags: needinfo?(tnikkel)
Attachment #8553439 - Flags: review?(matt.woodrow)
Attachment #8553439 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/49b107ba5bee
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
I think there's still an issue with position:fixed. Images with position:fixed are displayed only partially in certain cases for me. Happens on Win8.1 + current Nightly. Demo page, Ctrl-F5 if necessary: <!DOCTYPE html> <html> <head> <title>Test</title> <style type="text/css"> body { background: #ccc; } #fixed { top: 0px; right: 0px; position: fixed; } </style> </head> <body> <img alt="" src="https://mozorg.cdn.mozilla.net/media/img/styleguide/identity/firefox/what-to-look-for.png"> <img alt="" src="https://mozorg.cdn.mozilla.net/media/img/styleguide/identity/firefox/what-to-look-for.png" id="fixed"> </body> </html>
(In reply to Maxime from comment #16) > I think there's still an issue with position:fixed. > Images with position:fixed are displayed only partially in certain cases for > me. > > Happens on Win8.1 + current Nightly. > > Demo page, Ctrl-F5 if necessary: Please file a separate bug.
Flags: needinfo?(maxaks)
(In reply to :Gijs Kruitbosch from comment #17) > Please file a separate bug. https://bugzilla.mozilla.org/show_bug.cgi?id=1130191
Flags: needinfo?(maxaks)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: