Closed Bug 1120823 Opened 10 years ago Closed 9 years ago

MediaCodecReader: Remove timeout in DecodeAudioDataSync() and DecodeVideoFrameSync().

Categories

(Core :: Audio/Video: Playback, defect)

x86_64
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: bechen, Assigned: bechen)

References

Details

I still think we should keep the timeout and "dispatch the same task to self taskqueue". It is because we call flush() on other tread by ResetDecode(). And the dispatch mechanism give us a change to break the infinite loop if the decoder can not output any data.
Hi Chris: How do you think about comment 1? For example: If I remove the timeout code, open a HTTP streaming by browser, then press back key when playing. The ResetDecode() function will stuck on Flush() because the VideoTaskQueue can not output data.
Flags: needinfo?(cpearce)
Why would the video decode not be able to output an error code in that case? Won't pressing the back key result in the HTTP stream being close, and cause a network error, that should propagate to MediaCodecReader::GetCodecOutputData()?
Flags: needinfo?(cpearce)
Component: Audio/Video → Audio/Video: Playback
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.