Georg Fritzsche [:gfritzsche] Reporter
	Description • 10 years ago

We need to migrate the Sync FHR provider to Telemetry.
That consists of:
* org.mozilla.sync.sync
* org.mozilla.sync.devices
* org.mozilla.sync.migration (soon, per bug 1097406)

	Georg Fritzsche [:gfritzsche] Reporter
	Comment 1 • 9 years ago

The numeric values here should be straight-forward to migrate to histograms or keyed histograms.
We can intercept e.g. at FxaMigrator.recordTelemetry():
https://hg.mozilla.org/mozilla-central/annotate/df3daecd381f/services/sync/modules/FxaMigrator.jsm#l515

I'm not so sure about the other paths off-hand, Mark can you maybe point to the rest?

	Georg Fritzsche [:gfritzsche] Reporter
	Comment 2 • 9 years ago

The fields that we need to port:
* https://hg.mozilla.org/mozilla-central/annotate/df3daecd381f/services/sync/modules/healthreport.jsm#l36
* https://hg.mozilla.org/mozilla-central/annotate/df3daecd381f/services/sync/modules/healthreport.jsm#l76
* https://ci.mozilla.org/job/mozilla-central-docs/Tree_Documentation/services/healthreport/healthreport/dataformat.html#org-mozilla-sync-devices

... I'm not sure off-hand about how to best cover the "daily last text" fields like |preferredProtocol| and |state| - Benjamin, do you have ideas?

	Benjamin Smedberg
	Comment 3 • 9 years ago

No. I think we need to understand what questions the sync team is trying to answer and then make sure the data answers those questions. It may be that this is already duplicated in telemetry.

	Mark Hammond [:markh] [:mhammond]
	Comment 4 • 9 years ago

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #3)
> No. I think we need to understand what questions the sync team is trying to
> answer and then make sure the data answers those questions.

The SyncMeasurement1 fields are tracking the sync enabled state, success and error counts and the protocol version per day.  I'm not sure if the dashboards *actually* answer that though.

The SyncMigrationMeasurement1 fields are basically tracking how the user interacts with the migration UI, and how far they get through the migration process, so we can identify if there is anywhere in the migration flows causing the user to "stall".  Note that currently we have *zero* visibility into this data due to the complexities in accessing the FHR data, and this is a problem for us.  We *really* want this data by the time 36 hits the release channel (and it's somewhat ironic that we chose FHR over telemetry to ensure we had good data from the release channel, then realized the complexities in actually getting the data means we have zero visibility on any channel)

(In reply to Georg Fritzsche [:gfritzsche] [away Feb 27 - March 15] from comment #1)
> The numeric values here should be straight-forward to migrate to histograms
> or keyed histograms.
> We can intercept e.g. at FxaMigrator.recordTelemetry():
> https://hg.mozilla.org/mozilla-central/annotate/df3daecd381f/services/sync/
> modules/FxaMigrator.jsm#l515
> 
> I'm not so sure about the other paths off-hand, Mark can you maybe point to
> the rest?

IIUC, services/sync/modules/healthreport.jsm works primarily form observers, so all measurements in that file could probably be ported to telemetry without touching other files (ie, by sticking to the observer pattern already used).  I hope that answers the question.

	Georg Fritzsche [:gfritzsche] Reporter
	Comment 5 • 9 years ago

Benjamin, you wanted to check on the use-case here - any update?

	Benjamin Smedberg
	Comment 6 • 9 years ago

There is an email thread about this, clearing NI.

	Thomas Huelbert
	Comment 7 • 9 years ago

NI to BDS - is this issue still valid, if so whats the time frame for resolution?

	Benjamin Smedberg
	Comment 8 • 9 years ago

Since I haven't gotten a clear answer, I think we should close this INCOMPLETE and if the sync team comes up with a clear set of questions we can reopen.