Closed
Bug 1121036
Opened 10 years ago
Closed 10 years ago
In Edit Mode, when creating a new group near the bottom of screen, animate expanded group into full view
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(b2g-v2.2 fixed, b2g-master fixed)
RESOLVED
FIXED
2.2 S7 (6mar)
People
(Reporter: kcaldwell, Assigned: cwiiis)
References
Details
(Keywords: polish, Whiteboard: [systemsfe])
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
kgrandon
:
review+
bajaj
:
approval-gaia-v2.2+
|
Details |
In edit mode, when user creates a new group near or close to the bottom of the visible screen area, when new group is created, it grows to the default size of one row and the icon snaps into the first slot.
The new group snaps up to make sure it’s visible - animate group up into full view for the user.
Updated•10 years ago
|
Whiteboard: [systemsfe]
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8573190 -
Flags: review?(kgrandon)
Comment 3•10 years ago
|
||
Comment on attachment 8573190 [details]
[gaia] Cwiiis:bug1121036-focus-new-group > mozilla-b2g:master
This is looking pretty good code-wise (there is a jshint issue that you should fix), but I think we need just a little bit more tuning before landing.
The 750ms timeout is quite big, and something I tried cause the page to jump back to where it thinks it should be. Try this - with a bunch of expanded groups, scroll down the page slowly, collapsing groups as you're scrolling. The page will sort of jump to weird areas. I'm wondering if we can clear the timeout on scroll somehow. Maybe either with a scroll handler, or a temporary touchstart handler.
Flags: needinfo?(chrislord.net)
Attachment #8573190 -
Flags: review?(kgrandon)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8573190 [details]
[gaia] Cwiiis:bug1121036-focus-new-group > mozilla-b2g:master
Re-requesting review, I think this comment must have been for bug 1120884.
Flags: needinfo?(chrislord.net)
Attachment #8573190 -
Flags: review?(kgrandon)
Comment 5•10 years ago
|
||
Comment on attachment 8573190 [details]
[gaia] Cwiiis:bug1121036-focus-new-group > mozilla-b2g:master
Ugh, did I review the wrong bug? *sigh*
This looks good to me though, nice work!
Attachment #8573190 -
Flags: review?(kgrandon) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed,
polish
Updated•10 years ago
|
Keywords: checkin-needed
Comment 6•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/379a39ad228cb98d7625438b9ababa8a3fccd171
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Target Milestone: --- → 2.2 S7 (6mar)
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8573190 [details]
[gaia] Cwiiis:bug1121036-focus-new-group > mozilla-b2g:master
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Expanding a group doesn't bring the group into best focus. Small polish issue.
[Testing completed]: Automated and manual testing, and been on master for a while with no reports of bad behaviour.
[Risk to taking this patch] (and alternatives if risky): Low risk, single-line change.
[String changes made]: None.
Attachment #8573190 -
Flags: approval-gaia-v2.2?
Comment 8•10 years ago
|
||
(In reply to Chris Lord [:cwiiis] from comment #7)
> Comment on attachment 8573190 [details]
> [gaia] Cwiiis:bug1121036-focus-new-group > mozilla-b2g:master
>
> [Approval Request Comment]
> [Bug caused by] (feature/regressing bug #):
> [User impact] if declined: Expanding a group doesn't bring the group into
> best focus. Small polish issue.
> [Testing completed]: Automated and manual testing, and been on master for a
> while with no reports of bad behaviour.
> [Risk to taking this patch] (and alternatives if risky): Low risk,
> single-line change.
> [String changes made]: None.
I do want to remind, that we want to avoid the code churn on 2.2 at this time keeping the FC/CC timelines in mind and hence the branch is open for release blockers only at this point. We have been lenient in taking any low risk fixes where worthy(and sometimes that's debatable, hence we stick to blockers only) but these will start getting minused soon, so please don't be disheartened!
Updated•10 years ago
|
Attachment #8573190 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Comment 9•10 years ago
|
||
status-b2g-v2.2:
--- → fixed
status-b2g-master:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•