Closed
Bug 1121194
Opened 10 years ago
Closed 10 years ago
Support vertical panning for the flamegraph in the new performance tool
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(firefox39 fixed)
RESOLVED
FIXED
Firefox 39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: vporof, Assigned: vporof)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•10 years ago
|
Blocks: perf-tool-v2
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8575470 [details] [diff] [review]
v1
Review of attachment 8575470 [details] [diff] [review]:
-----------------------------------------------------------------
Slick. When trying it out, one thing I kept running into, not sure if something we can do right now. When dragging up, once you're in the overview chart area and you mouseup the overview graph will change selection, most likely moving you away of the flames you were looking at. Maybe similar to the other bugs where we should clamp down the mouse events to the originator (mousedown) graph
::: browser/devtools/shared/widgets/FlameGraph.jsm
@@ +505,3 @@
> */
> _drawBlocksFill: function(
> + color, blocks, verticalOffset, dataOffset, dataScale,
how do you remember this argument order?!
Attachment #8575470 -
Flags: review?(jsantell) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•