Bug 789771 added an OSX refvaiable to the reftest condition sandbox, whose value is a float with the OS X version. This can be used in conditions like fails-if(OSX<10.8). On 10.10 (Yosemite), however, it has the value 10.1. We should probably change the variable to OSX10 and the value to the bit after the float, as an integer.

This is visible in http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/cedar-macosx64/1421186363/cedar_yosemite_test-reftest-bm107-tests1-macosx-build2.txt.gz .

Alternately, perhaps strip out the dot and just make it an integer (with a leading zero for the minor version) like 10.8 -> 1008, 10.10 -> 1010.

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2) > Alternately, perhaps strip out the dot and just make it an integer (with a > leading zero for the minor version) like 10.8 -> 1008, 10.10 -> 1010. Yeah, that's probably better.

https://hg.mozilla.org/try/pushloghtml?changeset=294706c18a9f https://treeherder.mozilla.org/#/jobs?repo=try&revision=294706c18a9f https://tbpl.mozilla.org/?tree=Try&rev=294706c18a9f

Using undefined has the advantage that we can use < and > tests with the OSX variable. (We currently have no such tests in the tree, perhaps partly because they didn't work with non-OSX being 0.)

Comment on attachment 8549387 [details] [diff] [review] patch 1 - Make the OSX variable in the reftest condition sandbox be an integer (1006, 1010) so that it scales for 10.10, and undefined for non-Mac rather than 0 Review of attachment 8549387 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/tools/reftest/reftest.js @@ +669,5 @@ > httpProps.forEach((x) => sandbox.http[x] = hh[x]); > > + // Set OSX to be the Mac OS X version, as an integer, or undefined > + // for other platforms. The integer is formed by 100 times the > + // major verion plus the minor version, so 1006 for 10.6, 1010 for typo: version

Comment on attachment 8549388 [details] [diff] [review] patch 2 - Update reftest and crashtest manifests for new OSX variable in condition sandbox Review of attachment 8549388 [details] [diff] [review]: ----------------------------------------------------------------- Given that we don't have tests running on anything >10.8 in automation (10.10 was just stood up on Cedar but is not green yet) I suspect a lot of these "OSX==1008" actually want to be "OSX>1008" and likewise "OSX==1007||OSX==1008" might really want to be "OSX>1007".

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #8) > Given that we don't have tests running on anything >10.8 in automation > (10.10 was just stood up on Cedar but is not green yet) I suspect a lot of > these "OSX==1008" actually want to be "OSX>1008" and likewise > "OSX==1007||OSX==1008" might really want to be "OSX>1007". Agreed; that's the next step.

https://hg.mozilla.org/integration/mozilla-inbound/rev/6084da03dcd8 https://hg.mozilla.org/integration/mozilla-inbound/rev/4323060230fb

https://hg.mozilla.org/mozilla-central/rev/6084da03dcd8 https://hg.mozilla.org/mozilla-central/rev/4323060230fb