Since implementation of pairing process via WIP of bug 1119734, I meet a bug about no device name from the 'onpairingconfirmationreq' event.

======== Log ========== I/Jamin (17456): BluetoothPairingListener::DispatchPairingEvent I/Jamin (17456): after sleep BluetoothPairingListener::Run I/Bluetooth Manager(17456): Content JS LOG: --> evt = [object BluetoothPairingEvent] I/Bluetooth Manager(17456): at PairManager._onPairingConfirmationReq (app://bluetooth.gaiamobile.org/js/pair_manager_v2.js:133:6) I/Bluetooth Manager(17456): Content JS LOG: --> evt.device = [object BluetoothDevice] I/Bluetooth Manager(17456): at PairManager._onPairingConfirmationReq (app://bluetooth.gaiamobile.org/js/pair_manager_v2.js:134:6) I/Bluetooth Manager(17456): Content JS LOG: --> evt.device.name = I/Bluetooth Manager(17456): at PairManager._onPairingConfirmationReq (app://bluetooth.gaiamobile.org/js/pair_manager_v2.js:135:6)

Note this bug was affected by bug 1100818.

Comment on attachment 8549398 [details] [diff] [review] Patch 1 (v1): Append device name to BluetoothDevice in BluetoothPairingEvent Review of attachment 8549398 [details] [diff] [review]: ----------------------------------------------------------------- It looks good to me. ::: dom/bluetooth2/BluetoothPairingListener.cpp @@ +105,5 @@ > > + /** > + * Create a temporary device with deviceAddress and deviceName > + * > + * FIXME: Replace BluetoothDevice in BluetootPairingEvent with device I prefer to remove FIXME and open an another bug for tracking this.

Comment on attachment 8549398 [details] [diff] [review] Patch 1 (v1): Append device name to BluetoothDevice in BluetoothPairingEvent Looks good to me. :)

Remove comment addressed in comment 3 since the change involves API revision. I'll discuss with gaia dev to decide whether to revise API later.

https://hg.mozilla.org/integration/b2g-inbound/rev/85c5c57b50dd No try since the affected folder (dom/bluetooth2) is not built by default.