Closed
Bug 1121658
Opened 10 years ago
Closed 10 years ago
Remove DestroyDecodedStream() from MediaDecoder::SetDormantIfNecessary()
Categories
(Core :: Audio/Video, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file)
(deleted),
patch
|
roc
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1121064 +++
Call DestroyDecodedStream() in MediaDecoder::SetDormantIfNecessary() seem not a correct way to stop MediaStream in this situation.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Updated•10 years ago
|
Priority: -- → P1
Assignee | ||
Comment 3•10 years ago
|
||
FYI: Diagram related to HTMLMediaElement::MozCaptureStream()
https://github.com/sotaroikeda/firefox-diagrams/blob/master/media/dom_media_HTMLMediaElement_MozCaptureStream_FirefoxOS_2_2.pdf?raw=true
Assignee | ||
Updated•10 years ago
|
Attachment #8549129 -
Flags: review?(cpearce)
Assignee | ||
Updated•10 years ago
|
Comment 4•10 years ago
|
||
Comment on attachment 8549129 [details] [diff] [review]
patch - Remove DestroyDecodedStream() from MediaDecoder::SetDormantIfNecessary()
Review of attachment 8549129 [details] [diff] [review]:
-----------------------------------------------------------------
Probably better to get Roc to check this, since it touches MediaStreams.
Attachment #8549129 -
Flags: review?(cpearce) → review?(roc)
Attachment #8549129 -
Flags: review?(roc) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment 7•10 years ago
|
||
Comment on attachment 8549129 [details] [diff] [review]
patch - Remove DestroyDecodedStream() from MediaDecoder::SetDormantIfNecessary()
Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Youtube playback can use more resources. Less consistent testing.
[Describe test coverage new/current, TreeHerder]: Landed on m-c.
[Risks and why]: Small, isolated change, but does affect non-MSE playback.
[String/UUID change made/needed]: None.
Attachment #8549129 -
Flags: approval-mozilla-beta?
Attachment #8549129 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Updated•10 years ago
|
Attachment #8549129 -
Flags: approval-mozilla-beta?
Attachment #8549129 -
Flags: approval-mozilla-beta+
Attachment #8549129 -
Flags: approval-mozilla-aurora?
Attachment #8549129 -
Flags: approval-mozilla-aurora+
Comment 8•10 years ago
|
||
Comment 9•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•