Closed Bug 1121782 Opened 10 years ago Closed 9 years ago

Win7 aero: Forward button appears to be disabled when it isn't

Categories

(Firefox :: Theme, defect)

35 Branch
x86_64
Windows 7
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: jfleshman, Unassigned)

References

Details

(Keywords: regression, Whiteboard: fixed by bug 1173744)

Attachments

(3 files)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0 Build ID: 20150108202552 Steps to reproduce: 1. Go to any page on the internet, then to any other page on the internet. 2. Press the back button to return to the first page. 3. Forward button appears. Actual results: Forward button looks like it's disabled -- border is less distinct than the one on the back button was, and it's the same color as the surrounding toolbar instead of being visually distinct from it. Expected results: An active forward button should have the same color and border as an active back button.
Attached image back-fwd-win7.PNG (deleted) —
This is what they look like for me. The colors look the same to me - definitely not "disabled". Can you provide a screenshot of what you're seeing that makes you feel differently?
Flags: needinfo?(jfleshman)
Attached image Forward button with no hover (deleted) —
This is how the forward button appears when I back up to a previous page. It appears the same color as the surrounding toolbar/address bar. Compare to the back button, which looks (and is) clickable.
Flags: needinfo?(jfleshman)
Attached image Forward button with hover (deleted) —
When mousing over the forward button, it now appears clickable. But the browser should make it look that way all the time, not just when hovering (IMO).
(In reply to Jason Fleshman from comment #3) > Created attachment 8549982 [details] > Forward button with hover > > When mousing over the forward button, it now appears clickable. But the > browser should make it look that way all the time, not just when hovering > (IMO). I definitely agree that this look is the one we should be using even without hovering. I'm trying to figure out why you're seeing something different from me... Can you reproduce this if you restart Firefox in safe mode (Help > Restart with add-ons disabled) ? If so, can you tell me: 1) your windows theme (Aero, Aero basic, custom theme, ...) 2) your font size settings from the control panel (110%, 150% - it looks like you're using hidpi, at least). Thank you!
Flags: needinfo?(jfleshman)
I've restarted in safe mode as requested and the problem still shows itself. My Windows theme is standard Aero (the kind with the see-through window frames), and my system zoom is set to "larger", which is 150%.
Component: Untriaged → Toolbars and Customization
Component: Toolbars and Customization → Theme
Flags: needinfo?(jfleshman) → needinfo?(gijskruitbosch+bugs)
The relevant CSS here is: window:not([chromehidden~="toolbar"]) #urlbar-wrapper > .toolbarbutton-1:-moz-any([disabled],:not([open]):not([disabled]):not(:active)) > .toolbarbutton-icon { border-color: hsla(210,4%,10%,.1); } at http://hg.mozilla.org/mozilla-central/annotate/dcb4c5573aef/browser/themes/windows/browser.css#l788 introduced in bug 960517. I don't know why this specific rule was necessary... although if you remove it, the button doesn't have a border at all anymore. It looks like we forgot to override it for win7 (and perhaps also winxp / classic... we'd need to look). Mike, does that analysis look right to you? For the record, on aero the url bar has borders that have this color: border-color: hsla(210,54%,20%,.35) hsla(210,54%,20%,.37) hsla(210,54%,20%,.4); which are much more saturated, a bit lighter, and more opaque... Likewise for the box-shadow of the back button, which is much more opaque: box-shadow: 0 1px 0 hsla(0,0%,100%,.3) inset, 0 0 0 1px hsla(0,0%,100%,.3) inset, 0 0 0 1px hsla(210,54%,20%,.25), 0 1px 0 hsla(210,54%,20%,.35) !important; (in fact, is so even when disabled...)
Blocks: 960517
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(mdeboer)
Summary: Forward button appears to be disabled when it isn't → Win7 aero: Forward button appears to be disabled when it isn't
Keywords: regression
Depends on: 1173744
Flags: needinfo?(mdeboer)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: fixed by bug 1173744
Flags: qe-verify+
QA Contact: cornel.ionce
I can confirm that the latest Nightly, build ID: 20151015030233 is no longer affected by this issue. Tested on Windows 7 32bit and Windows 7 64bit.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: