Closed
Bug 1121804
Opened 10 years ago
Closed 10 years ago
[LayerScope] Add an option to enable/disable the copying and transmitting of texture data.
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla38
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: boris, Assigned: boris)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(2 files, 2 obsolete files)
(deleted),
patch
|
u480271
:
review+
|
Details | Diff | Splinter Review |
(deleted),
image/png
|
Details |
The performance of generating and transmitting packets of texture data is not good enough. (because the size of texture data is too large, and we should read pixels from GPU. It costs much time.), and I think we want to show the texture data only on some specific frames. Therefore, adding an option to control this part could let us use Layerscope more efficiently.
Maybe we could use Websocket to send the message from the viewer and gecko can dynamically turn on/off the reading/sending of texture data.
Assignee | ||
Updated•10 years ago
|
Summary: [LayerScope] Add an option to enable/disable the generation and transmission of texture data. → [LayerScope] Add an option to enable/disable the copying and transmitting of texture data.
Assignee | ||
Updated•10 years ago
|
Blocks: LayerScope
Updated•10 years ago
|
Whiteboard: [gfx-noted]
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → boris.chiou
Assignee | ||
Comment 1•10 years ago
|
||
A explanation about websocket packet format (for sending and receiving on the server side):
http://stackoverflow.com/questions/8125507/how-can-i-send-and-receive-websocket-messages-on-the-server-side
Assignee | ||
Comment 2•10 years ago
|
||
(In reply to Boris Chiou [:boris] from comment #1)
> A explanation about websocket packet format (for sending and receiving on
> the server side):
> http://stackoverflow.com/questions/8125507/how-can-i-send-and-receive-
> websocket-messages-on-the-server-side
another reference document:
https://developer.mozilla.org/en-US/docs/WebSockets/Writing_WebSocket_servers
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Boris Chiou [:boris] from comment #2)
> (In reply to Boris Chiou [:boris] from comment #1)
> > A explanation about websocket packet format (for sending and receiving on
> > the server side):
> > http://stackoverflow.com/questions/8125507/how-can-i-send-and-receive-
> > websocket-messages-on-the-server-side
>
> another reference document:
> https://developer.mozilla.org/en-US/docs/WebSockets/Writing_WebSocket_servers
In this bug, I will implement a light-weight websocket frame parser to handle specific packets from layerscope client side.
Reference: https://dxr.mozilla.org/mozilla-central/source/netwerk/protocol/websocket/WebSocketChannel.cpp#1421
Status: NEW → ASSIGNED
Assignee | ||
Updated•10 years ago
|
Summary: [LayerScope] Add an option to enable/disable the copying and transmitting of texture data. → (LayerScope) Add an option to enable/disable the copying and transmitting of texture data.
Assignee | ||
Updated•10 years ago
|
Summary: (LayerScope) Add an option to enable/disable the copying and transmitting of texture data. → [LayerScope] Add an option to enable/disable the copying and transmitting of texture data.
Comment hidden (obsolete) |
Assignee | ||
Comment 5•10 years ago
|
||
1. Fix websocket listener, and implement a light-wight parser.
1. Handle the messages from clients by protobuf
2. Handle disconnection while receiving the close message.
Attachment #8555627 -
Attachment is obsolete: true
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8556382 [details] [diff] [review]
Add websocket message listener (v1)
Review of attachment 8556382 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/layers/LayerScope.cpp
@@ -189,2 @@
>
> - bool WebSocketHandshake(nsTArray<nsCString>& aProtocolString)
ReadInputStreamData, WebSocketHandshake, OpenStream, WriteToStream are just moved to the bottom.
@@ +981,5 @@
> + return true;
> +}
> +
> +nsresult
> +LayerScopeWebSocketHandler::HandleSocketMessage(nsIAsyncInputStream *aStream)
HandleSocketMessage, ProcessInput, ApplyMask, HandleDataFrame, and CloseConnection are newly added.
Assignee | ||
Comment 7•10 years ago
|
||
1. Fix websocket listener, and implement a light-wight parser.
2. Handle the messages from clients by protobuf
3. Handle disconnection while receiving the close message.
Attachment #8556382 -
Attachment is obsolete: true
Assignee | ||
Comment 8•10 years ago
|
||
1. We can handle disconnection now because we can receive and parse the "close connection" message from clients properly.
2. Send command messages from clients. Add two checkboxs to enable/disable the dumping the content (layer tree or layer buffer).
Assignee | ||
Updated•10 years ago
|
Attachment #8556851 -
Flags: review?(dglastonbury)
Assignee | ||
Comment 9•10 years ago
|
||
(In reply to Boris Chiou [:boris] from comment #7)
> Created attachment 8556851 [details] [diff] [review]
> Add websocket message listener (v2)
>
> 1. Fix websocket listener, and implement a light-wight parser.
> 2. Handle the messages from clients by protobuf
> 3. Handle disconnection while receiving the close message.
try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd69e3c38364
Attachment #8556851 -
Flags: review?(dglastonbury) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 10•10 years ago
|
||
Keywords: checkin-needed
Comment 11•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•