Closed
Bug 1121814
Opened 10 years ago
Closed 10 years ago
[Stingray][smart-system] use latest NotificationHelper to show notification
Categories
(Firefox OS Graveyard :: Gaia, defect)
Firefox OS Graveyard
Gaia
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: johnhu, Assigned: rohan1395)
References
Details
Attachments
(1 file)
1) https://github.com/mozilla-b2g/gaia/blob/master/tv_apps/app-deck/js/context_menu.js#L77-L84
This is fortunately not true.
1) bluetooth seems to be using old NotificationHelper. It should be synced with the one from shared, which returns a Promise and support L10n API properly.
2) tv_apps/smart-system/js/captive_portal.js, tv_apps/smart-system/js/screenshot.js and tv_apps/smart-system/js/devtools/logshake.js should use the new NotificationHelper instead of raw W3C Notification.
3) Same for tv_apps/smart-system/js/external_storage_monitor.js
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → im
Comment 1•10 years ago
|
||
You should just switch to https://github.com/mozilla-b2g/gaia/blob/master/shared/js/notification_helper.js
Reporter | ||
Comment 2•10 years ago
|
||
I had created a WIP 11 days ago:
https://github.com/huchengtw-moz/gaia/commit/3792f421a87e3a87b1dfd6f93d296756ee87696a
Because I got the high priority works recently, I cannot work on it. If someone want to take it, please steal the bug. I will be back once those works done.
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8557449 -
Flags: review?(timdream)
Updated•10 years ago
|
Attachment #8557449 -
Flags: review?(timdream) → review?(im)
Reporter | ||
Comment 4•10 years ago
|
||
Rohan
Thanks for giving the patch. I reassign this bug to you. And I will review the patch in this week.
Assignee: im → rohan1395
Reporter | ||
Comment 5•10 years ago
|
||
Comment on attachment 8557449 [details]
Gaia PR
Looks good to me. Thank you. I will land the code for you.
Attachment #8557449 -
Flags: review?(im) → review+
Reporter | ||
Comment 6•10 years ago
|
||
merged to master:
https://github.com/mozilla-b2g/gaia/commit/4a99698691bd09670e81b675cada794815eb8bd0
gaia try is all green:
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=b9430f804317
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•10 years ago
|
||
I was wondering if this also fixed bug 967925 ?
Flags: needinfo?(im)
Reporter | ||
Comment 8•10 years ago
|
||
Well, this is a good question. If you apply the patch to "phone's" system app who is at /apps/system/, it is true that you also fixed bug 967925.
But smart system is for smart screen. So, please find the bug similar to this one and fix it.
Flags: needinfo?(im)
Reporter | ||
Comment 9•10 years ago
|
||
Here is the information about smart screen:
https://wiki.mozilla.org/FirefoxOS/Stingray/SmartScreen/
You need to log in
before you can comment on or make changes to this bug.
Description
•